ceph
/
ceph-ansible
mirror of https://github.com/ceph/ceph-ansible.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
ceph-ansible/roles/ceph-container-engine/tasks/pre_requisites/prerequisites.yml

42 lines
1012 B
YAML
Raw Normal View History

docker: Fix #1303 Install package from official repos rather than pip when using RHEL. This commit fix https://bugzilla.redhat.com/show_bug.cgi?id=1420855 Also this commit Refact all `roles/ceph-*/tasks/docker/pre_requisite.yml` to avoid a lot of duplicated code. Fix: #1303 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2017-02-22 00:58:24 +08:00
---
ceph-container-common: modify requirement flow Until now it was not possible to install a specific container package because it was somehow hardcoded. This patch allows to override the container package name (docker.io vs docker-ce) and refacts the package installation. This could be achieve via the container_package_name variable. Instead of using one task per distribution we can set the package and service name in vars. This allows to have a unified package task. Also refactorize the debian_prerequisites tasks because the content was outdated. https://docs.docker.com/install/linux/docker-ce/debian/ https://docs.docker.com/install/linux/docker-ce/ubuntu/ Resolves: #3609 Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
2019-04-16 21:33:02 +08:00
- name: include specific variables
include_vars: "{{ item }}"
with_first_found:
- "{{ ansible_distribution }}-{{ ansible_distribution_major_version }}.yml"
- "{{ ansible_os_family }}.yml"
use blocks directives to group tasks Using block directives simplifies the playbooks and makes them more readable. Fixes: https://github.com/ceph/ceph-ansible/issues/2835 Signed-off-by: Rishabh Dave <ridave@redhat.com>
2018-09-07 20:45:43 +08:00
- name: debian based systems tasks
ceph-container-common: modify requirement flow Until now it was not possible to install a specific container package because it was somehow hardcoded. This patch allows to override the container package name (docker.io vs docker-ce) and refacts the package installation. This could be achieve via the container_package_name variable. Instead of using one task per distribution we can set the package and service name in vars. This allows to have a unified package task. Also refactorize the debian_prerequisites tasks because the content was outdated. https://docs.docker.com/install/linux/docker-ce/debian/ https://docs.docker.com/install/linux/docker-ce/ubuntu/ Resolves: #3609 Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
2019-04-16 21:33:02 +08:00
include_tasks: debian_prerequisites.yml
"when" keyword should precede "block" keyword Otherwise the reader is forced to search for "when" when blocks are too long. Signed-off-by: Rishabh Dave <ridave@redhat.com>
2019-03-28 16:13:30 +08:00
when:
ceph-container-common: modify requirement flow Until now it was not possible to install a specific container package because it was somehow hardcoded. This patch allows to override the container package name (docker.io vs docker-ce) and refacts the package installation. This could be achieve via the container_package_name variable. Instead of using one task per distribution we can set the package and service name in vars. This allows to have a unified package task. Also refactorize the debian_prerequisites tasks because the content was outdated. https://docs.docker.com/install/linux/docker-ce/debian/ https://docs.docker.com/install/linux/docker-ce/ubuntu/ Resolves: #3609 Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
2019-04-16 21:33:02 +08:00
- ansible_os_family == 'Debian'
improve coding style Keywords requiring only one item shouldn't express it by creating a list with single item. Signed-off-by: Rishabh Dave <ridave@redhat.com>
2019-04-01 23:46:15 +08:00
tags: with_pkg
docker: Fix #1303 Install package from official repos rather than pip when using RHEL. This commit fix https://bugzilla.redhat.com/show_bug.cgi?id=1420855 Also this commit Refact all `roles/ceph-*/tasks/docker/pre_requisite.yml` to avoid a lot of duplicated code. Fix: #1303 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2017-02-22 00:58:24 +08:00
# ensure extras enabled for docker
- name: enable extras on centos
yum_repository:
name: extras
state: present
enabled: yes
when:
- ansible_distribution == 'CentOS'
ansible: use 'bool' filter on boolean conditionals By running ceph-ansible there are a lot ``[DEPRECATION WARNING]`` like these: ``` [DEPRECATION WARNING]: evaluating containerized_deployment as a bare variable, this behaviour will go away and you might need to add |bool to the expression in the future. Also see CONDITIONAL_BARE_VARS configuration toggle.. This feature will be removed in version 2.12. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg. ``` Now appended ``| bool`` on a lot of the affected variables. Sometimes the coding style from ``variable|bool`` changed to ``variable | bool`` *(with spaces at the pipe)*. Closes: #4022 Signed-off-by: L3D <l3d@c3woc.de>
2019-05-22 16:02:42 +08:00
- ceph_docker_enable_centos_extra_repo | bool
docker: Fix #1303 Install package from official repos rather than pip when using RHEL. This commit fix https://bugzilla.redhat.com/show_bug.cgi?id=1420855 Also this commit Refact all `roles/ceph-*/tasks/docker/pre_requisite.yml` to avoid a lot of duplicated code. Fix: #1303 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2017-02-22 00:58:24 +08:00
tags:
with_pkg
container: move lvm2 package installation Before this patch, the lvm2 package installation was done during the ceph-osd role. However we were running ceph-volume command in the ceph-config role before ceph-osd. If lvm2 wasn't installed then the ceph-volume command fails: error checking path "/run/lock/lvm": stat /run/lock/lvm: no such file or directory This wasn't visible before because lvm2 was automatically installed as docker dependency but it's not the same for podman on CentOS 8. Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
2020-01-03 04:50:24 +08:00
- name: install container and lvm2 packages
ceph-container-common: modify requirement flow Until now it was not possible to install a specific container package because it was somehow hardcoded. This patch allows to override the container package name (docker.io vs docker-ce) and refacts the package installation. This could be achieve via the container_package_name variable. Instead of using one task per distribution we can set the package and service name in vars. This allows to have a unified package task. Also refactorize the debian_prerequisites tasks because the content was outdated. https://docs.docker.com/install/linux/docker-ce/debian/ https://docs.docker.com/install/linux/docker-ce/ubuntu/ Resolves: #3609 Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
2019-04-16 21:33:02 +08:00
package:
container: move lvm2 package installation Before this patch, the lvm2 package installation was done during the ceph-osd role. However we were running ceph-volume command in the ceph-config role before ceph-osd. If lvm2 wasn't installed then the ceph-volume command fails: error checking path "/run/lock/lvm": stat /run/lock/lvm: no such file or directory This wasn't visible before because lvm2 was automatically installed as docker dependency but it's not the same for podman on CentOS 8. Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
2020-01-03 04:50:24 +08:00
name: ['{{ container_package_name }}', '{{ container_binding_name }}', 'lvm2']
ceph-container-common: modify requirement flow Until now it was not possible to install a specific container package because it was somehow hardcoded. This patch allows to override the container package name (docker.io vs docker-ce) and refacts the package installation. This could be achieve via the container_package_name variable. Instead of using one task per distribution we can set the package and service name in vars. This allows to have a unified package task. Also refactorize the debian_prerequisites tasks because the content was outdated. https://docs.docker.com/install/linux/docker-ce/debian/ https://docs.docker.com/install/linux/docker-ce/ubuntu/ Resolves: #3609 Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
2019-04-16 21:33:02 +08:00
update_cache: true
container: move lvm2 package installation Before this patch, the lvm2 package installation was done during the ceph-osd role. However we were running ceph-volume command in the ceph-config role before ceph-osd. If lvm2 wasn't installed then the ceph-volume command fails: error checking path "/run/lock/lvm": stat /run/lock/lvm: no such file or directory This wasn't visible before because lvm2 was automatically installed as docker dependency but it's not the same for podman on CentOS 8. Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
2020-01-03 04:50:24 +08:00
register: result
until: result is succeeded
improve coding style Keywords requiring only one item shouldn't express it by creating a list with single item. Signed-off-by: Rishabh Dave <ridave@redhat.com>
2019-04-01 23:46:15 +08:00
tags: with_pkg
container: use tmpfiles.d to creates /run/ceph instead of using `RuntimeDirectory` parameter in systemd unit files, let's use a systemd `tmpfiles.d` to ensure `/run/ceph`. Explanation: `podman` doesn't create the `/var/run/ceph` if it doesn't exist the time where the container is run while `docker` used to create it. In case of `switch_to_containers` scenario, `/run/ceph` gets created by a tmpfiles.d systemd file; when switching to containers, the systemd unit file complains because `/run/ceph` already exists The better fix would be to ensure `/usr/lib/tmpfiles.d/ceph-common.conf` is removed and only rely on `RuntimeDirectory` from systemd unit file parameter but we come from a non-containerized environment which is already running, it means `/run/ceph` is already created and when starting the unit to start the container, systemd will still complain and we can't simply remove the directory if daemons are collocated. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2019-02-10 15:21:43 +08:00
ceph-container-common: modify requirement flow Until now it was not possible to install a specific container package because it was somehow hardcoded. This patch allows to override the container package name (docker.io vs docker-ce) and refacts the package installation. This could be achieve via the container_package_name variable. Instead of using one task per distribution we can set the package and service name in vars. This allows to have a unified package task. Also refactorize the debian_prerequisites tasks because the content was outdated. https://docs.docker.com/install/linux/docker-ce/debian/ https://docs.docker.com/install/linux/docker-ce/ubuntu/ Resolves: #3609 Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
2019-04-16 21:33:02 +08:00
- name: start container service
container-common: Enable docker on boot for ubuntu docker daemon is automatically started during package installation but the service isn't enabled on boot. Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
2019-04-02 00:12:52 +08:00
service:
ceph-container-common: modify requirement flow Until now it was not possible to install a specific container package because it was somehow hardcoded. This patch allows to override the container package name (docker.io vs docker-ce) and refacts the package installation. This could be achieve via the container_package_name variable. Instead of using one task per distribution we can set the package and service name in vars. This allows to have a unified package task. Also refactorize the debian_prerequisites tasks because the content was outdated. https://docs.docker.com/install/linux/docker-ce/debian/ https://docs.docker.com/install/linux/docker-ce/ubuntu/ Resolves: #3609 Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
2019-04-16 21:33:02 +08:00
name: '{{ container_service_name }}'
container-common: Enable docker on boot for ubuntu docker daemon is automatically started during package installation but the service isn't enabled on boot. Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
2019-04-02 00:12:52 +08:00
state: started
enabled: yes
tags:
with_pkg
global: add newline at end of file This commit re-add a newline at end of files when it's missing. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2019-08-23 02:29:40 +08:00
when: container_service_name == 'docker'