ceph
/
ceph-ansible
mirror of https://github.com/ceph/ceph-ansible.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
ceph-ansible/roles/ceph-validate/tasks/check_iscsi.yml

27 lines
844 B
YAML
Raw Normal View History

igw: valid client CHAP settings. The linux kernel target layer, LIO, does not support the iscsi target to mix ACLs that have chap enabled and disabled under the same tpg. This patch adds a check and fails if this type of setup is detected. This fixes Red Hat BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1615088 Signed-off-by: Mike Christie <mchristi@redhat.com>
2018-09-29 05:23:10 +08:00
---
igw: move gateway_ip_list check to validate role Signed-off-by: Mike Christie <mchristi@redhat.com> (cherry picked from commit d89d3e7cd6868dda59c5eec721a5d27f095a84df)
2019-05-30 23:54:04 +08:00
- name: make sure gateway_ip_list is configured
fail:
msg: "you must set a list of IPs (comma separated) for gateway_ip_list"
igw: drop gateway_ip_list for container setups The gateway_ip_list is not used in container setups, so drop it for that case. Signed-off-by: Mike Christie <mchristi@redhat.com> (cherry picked from commit b7b2213be18cf4fd827389fbc88613bf3e242b82)
2019-05-30 23:55:45 +08:00
when:
iscsi: refact deprecated variables This commit moves some old variables into ceph-defaults so we can move the `use_new_ceph_iscsi` fact in ceph-facts role in order. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com> (cherry picked from commit a781ce881c977d4300ff04be0bce405a32fe4665)
2019-07-02 21:30:12 +08:00
- gateway_ip_list == '0.0.0.0'
igw: drop gateway_ip_list for container setups The gateway_ip_list is not used in container setups, so drop it for that case. Signed-off-by: Mike Christie <mchristi@redhat.com> (cherry picked from commit b7b2213be18cf4fd827389fbc88613bf3e242b82)
2019-05-30 23:55:45 +08:00
- not containerized_deployment | bool
igw: Support ceph-iscsi package for install This adds support for the ceph-iscsi package during install. ceph-iscsi does not support setting up targets/gws, luns and clients with the current library/igw_* code. Going forward those tasks should be done with gwcli or dashboard. ceph-iscsi will only be used if the user has no iscsi objects setup so we do not break existing setups. The next patch will update the iscsigws.yml.sample to document that users must not setup any iscsi object if they want to use the new package and tools. Signed-off-by: Mike Christie <mchristi@redhat.com> (cherry picked from commit cbe66cec5239504f5532bfac09fcc0a295b22271)
2019-05-31 00:28:34 +08:00
- not use_new_ceph_iscsi | bool
igw: move gateway_ip_list check to validate role Signed-off-by: Mike Christie <mchristi@redhat.com> (cherry picked from commit d89d3e7cd6868dda59c5eec721a5d27f095a84df)
2019-05-30 23:54:04 +08:00
igw: Add check for missing iqn If the user is still using the older packages and does not setup the target iqn you will just get a vague error message later on. This adds a check during the validate task, so it is clear to the user. Signed-off-by: Mike Christie <mchristi@redhat.com> (cherry picked from commit 08a6d10c32beb5c2736b36487efb1860e868d74e)
2019-05-31 00:17:09 +08:00
- name: make sure gateway_iqn is configured
fail:
msg: "you must set a iqn for the iSCSI target"
when:
iscsi: refact deprecated variables This commit moves some old variables into ceph-defaults so we can move the `use_new_ceph_iscsi` fact in ceph-facts role in order. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com> (cherry picked from commit a781ce881c977d4300ff04be0bce405a32fe4665)
2019-07-02 21:30:12 +08:00
- gateway_iqn | length == 0
igw: Add check for missing iqn If the user is still using the older packages and does not setup the target iqn you will just get a vague error message later on. This adds a check during the validate task, so it is clear to the user. Signed-off-by: Mike Christie <mchristi@redhat.com> (cherry picked from commit 08a6d10c32beb5c2736b36487efb1860e868d74e)
2019-05-31 00:17:09 +08:00
- not containerized_deployment | bool
- not use_new_ceph_iscsi | bool
igw: valid client CHAP settings. The linux kernel target layer, LIO, does not support the iscsi target to mix ACLs that have chap enabled and disabled under the same tpg. This patch adds a check and fails if this type of setup is detected. This fixes Red Hat BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1615088 Signed-off-by: Mike Christie <mchristi@redhat.com>
2018-09-29 05:23:10 +08:00
- name: fail if unsupported chap configuration
fail:
msg: "Mixing clients with CHAP enabled and disabled is not supported."
iscsi: refact deprecated variables This commit moves some old variables into ceph-defaults so we can move the `use_new_ceph_iscsi` fact in ceph-facts role in order. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com> (cherry picked from commit a781ce881c977d4300ff04be0bce405a32fe4665)
2019-07-02 21:30:12 +08:00
with_items: "{{ client_connections }}"
igw: valid client CHAP settings. The linux kernel target layer, LIO, does not support the iscsi target to mix ACLs that have chap enabled and disabled under the same tpg. This patch adds a check and fails if this type of setup is detected. This fixes Red Hat BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1615088 Signed-off-by: Mike Christie <mchristi@redhat.com>
2018-09-29 05:23:10 +08:00
when:
- item.status is defined
- item.status == "present"
lint: Don't compare to empty string description = 'Use `when: var` rather than `when: var != ""` (or ' \ 'conversely `when: not var` rather than `when: var == ""`)' Signed-off-by: Sébastien Han <seb@redhat.com>
2018-11-01 23:03:16 +08:00
- item.chap
igw: valid client CHAP settings. The linux kernel target layer, LIO, does not support the iscsi target to mix ACLs that have chap enabled and disabled under the same tpg. This patch adds a check and fails if this type of setup is detected. This fixes Red Hat BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1615088 Signed-off-by: Mike Christie <mchristi@redhat.com>
2018-09-29 05:23:10 +08:00
- " '' in client_connections | selectattr('status', 'match', 'present') | map(attribute='chap') | list"