ceph
/
ceph-ansible
mirror of https://github.com/ceph/ceph-ansible.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
ceph-ansible/roles/ceph-facts/tasks/get_def_crush_rule_name.yml

20 lines
778 B
YAML
Raw Normal View History

osd: use default crush rule name when needed When `rule_name` isn't set in `crush_rules` the osd pool creation will fail. This commit adds a new fact `ceph_osd_pool_default_crush_rule_name` with the default crush rule name. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1817586 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2020-03-27 23:21:09 +08:00
---
- name: get current default crush rule details
library: add ceph_crush_rule module This adds ceph_crush_rule ansible module for replacing the command module usage with the ceph osd crush rule commands. This module can manage both erasure and replicated crush rules. Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
2020-11-10 01:16:41 +08:00
ceph_crush_rule:
name: null
cluster: "{{ cluster }}"
state: info
environment:
CEPH_CONTAINER_IMAGE: "{{ ceph_docker_registry + '/' + ceph_docker_image + ':' + ceph_docker_image_tag if containerized_deployment | bool else None }}"
CEPH_CONTAINER_BINARY: "{{ container_binary }}"
osd: use default crush rule name when needed When `rule_name` isn't set in `crush_rules` the osd pool creation will fail. This commit adds a new fact `ceph_osd_pool_default_crush_rule_name` with the default crush rule name. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1817586 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2020-03-27 23:21:09 +08:00
register: default_crush_rule_details
delegate_to: "{{ delegated_node | default(groups[mon_group_name][0]) }}"
run_once: true
- name: get current default crush rule name
set_fact:
ceph_osd_pool_default_crush_rule_name: "{{ item.rule_name }}"
ceph-facts: Fix get_def_crush_rule_name.yml in check mode This construct doesn't work as intended since ansible/ansible#74212: ``` item.stdout | default('{}') | from_json ``` That PR made the `command` module return `stdout` even in check mode (setting it to the empty string), so `default()` has no effect in that case and `from_json()` fails to parse an empty string. Instead, `default()` needs to be invoked with its second argument set to `True`, so that it replaces any `False` value (such as an empty string) with its first argument: ``` item.stdout | default('{}', True) | from_json ``` Signed-off-by: Benoît Knecht <bknecht@protonmail.ch> (cherry picked from commit 7684d892c083ea1e07ada163e78da9f0359b116f)
2021-12-13 23:36:27 +08:00
with_items: "{{ default_crush_rule_details.stdout | default('{}', True) | from_json }}"
osd: use default crush rule name when needed When `rule_name` isn't set in `crush_rules` the osd pool creation will fail. This commit adds a new fact `ceph_osd_pool_default_crush_rule_name` with the default crush rule name. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1817586 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2020-03-27 23:21:09 +08:00
run_once: True
ceph-facts: Fix get_def_crush_rule_name.yml in check mode This construct doesn't work as intended since ansible/ansible#74212: ``` item.stdout | default('{}') | from_json ``` That PR made the `command` module return `stdout` even in check mode (setting it to the empty string), so `default()` has no effect in that case and `from_json()` fails to parse an empty string. Instead, `default()` needs to be invoked with its second argument set to `True`, so that it replaces any `False` value (such as an empty string) with its first argument: ``` item.stdout | default('{}', True) | from_json ``` Signed-off-by: Benoît Knecht <bknecht@protonmail.ch> (cherry picked from commit 7684d892c083ea1e07ada163e78da9f0359b116f)
2021-12-13 23:36:27 +08:00
when: item.rule_id | int == osd_pool_default_crush_rule | int