ceph
/
ceph-ansible
mirror of https://github.com/ceph/ceph-ansible.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
ceph-ansible/roles/ceph-mon/tasks/secure_cluster.yml

16 lines
437 B
YAML
Raw Normal View History

Ability to secure cluster pools We set several flags to keep the cluster secure: * nodelete * nopgchange * nosizechange Signed-off-by: Sébastien Han <sebastien.han@enovance.com>
2015-05-12 17:18:12 +08:00
---
Re-arrange roles Trying to add more clarity in the role's task structure. Signed-off-by: leseb <seb@redhat.com>
2015-07-24 02:01:43 +08:00
- name: collect all the pools
mon: secure cluster on container Add the ability to protect pools on containerized clusters. Signed-off-by: Sébastien Han <seb@redhat.com>
2018-11-16 17:29:05 +08:00
command: >
{{ docker_exec_cmd }} rados --cluster {{ cluster }} lspools
lint: add changed_when to command Calling command should have changed_when false otherwise each time it runs it will show as 'changed' and this is irrelevant. Commands should not change things if nothing needs doing Signed-off-by: Sébastien Han <seb@redhat.com>
2018-10-30 22:51:32 +08:00
changed_when: false
Ability to secure cluster pools We set several flags to keep the cluster secure: * nodelete * nopgchange * nosizechange Signed-off-by: Sébastien Han <sebastien.han@enovance.com>
2015-05-12 17:18:12 +08:00
register: ceph_pools
Use check_mode instead of always_run This patch changes the `always_run: yes` task option to `check_mode: no` to avoid Ansible warnings.
2017-10-25 22:53:34 +08:00
check_mode: no
Ability to secure cluster pools We set several flags to keep the cluster secure: * nodelete * nopgchange * nosizechange Signed-off-by: Sébastien Han <sebastien.han@enovance.com>
2015-05-12 17:18:12 +08:00
- name: secure the cluster
mon: secure cluster on container Add the ability to protect pools on containerized clusters. Signed-off-by: Sébastien Han <seb@redhat.com>
2018-11-16 17:29:05 +08:00
command: >
{{ docker_exec_cmd }} ceph --cluster {{ cluster }} osd pool set {{ item[0] }} {{ item[1] }} true
lint: add changed_when to command Calling command should have changed_when false otherwise each time it runs it will show as 'changed' and this is irrelevant. Commands should not change things if nothing needs doing Signed-off-by: Sébastien Han <seb@redhat.com>
2018-10-30 22:51:32 +08:00
changed_when: false
Ability to secure cluster pools We set several flags to keep the cluster secure: * nodelete * nopgchange * nosizechange Signed-off-by: Sébastien Han <sebastien.han@enovance.com>
2015-05-12 17:18:12 +08:00
with_nested:
ceph-mon: fix the loop in `secure the cluster' task Deployment fails when the ``secure_cluster`` is false: TASK [ceph-mon : secure the cluster] ******************************************* fatal: [saceph-mon.vm.ceph.asheplyakov]: FAILED! => {"failed": true, "msg": "'dict object' has no attribute 'stdout_lines'"} fatal: [saceph-mon2.vm.ceph.asheplyakov]: FAILED! => {"failed": true, "msg": "'dict object' has no attribute 'stdout_lines'"} fatal: [saceph-mon3.vm.ceph.asheplyakov]: FAILED! => {"failed": true, "msg": "'dict object' has no attribute 'stdout_lines'"} A conditional include evaluates all included tasks with the (additional) conditional applied to every task [1]. Thus all tasks from `secure_cluster.yml' are always evaluated (with an additional 'when: secure_cluster' condition). The `secure the cluster' task iterates over ``ceph_pools.stdout_lines`` even if ``secure_cluster`` is false: in loops ansible applies conditional to every item (by design) [2]. However the `collect all the pools' task is skipped if the very same condition evaluates to false, which leaves the ``ceph_pools`` undefined, so the `secure the cluster' task fails: Provide the default (empty) list to avoid the problem. [1] http://docs.ansible.com/ansible/playbooks_conditionals.html#applying-when-to-roles-and-includes [2] http://docs.ansible.com/ansible/playbooks_conditionals.html#loops-and-conditionals Closes: #913 Signed-off-by: Alexey Sheplyakov <asheplyakov@mirantis.com>
2016-07-29 18:30:21 +08:00
- "{{ ceph_pools.stdout_lines|default([]) }}"
moving to ansible v2.2 compatibility Signed-off-by: Sébastien Han <seb@redhat.com> Co-Authored-By: Julien Francoz julien@francoz.net
2016-11-03 17:16:33 +08:00
- "{{ secure_cluster_flags }}"