ceph
/
ceph-ansible
mirror of https://github.com/ceph/ceph-ansible.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
ceph-ansible/roles/ceph-nfs/tasks/pre_requisite_non_container...

92 lines
3.3 KiB
YAML
Raw Normal View History

use blocks directives to group tasks Using block directives simplifies the playbooks and makes them more readable. Fixes: https://github.com/ceph/ceph-ansible/issues/2835 Signed-off-by: Rishabh Dave <ridave@redhat.com>
2018-09-07 20:45:43 +08:00
---
- name: debian based systems - repo handling
improve coding style Keywords requiring only one item shouldn't express it by creating a list with single item. Signed-off-by: Rishabh Dave <ridave@redhat.com>
2019-04-01 23:46:15 +08:00
when: ceph_origin == 'repository'
use blocks directives to group tasks Using block directives simplifies the playbooks and makes them more readable. Fixes: https://github.com/ceph/ceph-ansible/issues/2835 Signed-off-by: Rishabh Dave <ridave@redhat.com>
2018-09-07 20:45:43 +08:00
block:
- name: stable repos specific tasks
ceph-nfs: fixed condition for "stable repos specific tasks" The old condition would resolve to "when": "nfs_ganesha_stable - ceph_repository == 'community'" now it is "when": [ "nfs_ganesha_stable", "ceph_repository == 'community'" ] Please backport to stable-4.0 Signed-off-by: Bruceforce <markus.greis@gmx.de>
2019-05-12 17:40:05 +08:00
when:
ansible: use 'bool' filter on boolean conditionals By running ceph-ansible there are a lot ``[DEPRECATION WARNING]`` like these: ``` [DEPRECATION WARNING]: evaluating containerized_deployment as a bare variable, this behaviour will go away and you might need to add |bool to the expression in the future. Also see CONDITIONAL_BARE_VARS configuration toggle.. This feature will be removed in version 2.12. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg. ``` Now appended ``| bool`` on a lot of the affected variables. Sometimes the coding style from ``variable|bool`` changed to ``variable | bool`` *(with spaces at the pipe)*. Closes: #4022 Signed-off-by: L3D <l3d@c3woc.de>
2019-05-22 16:02:42 +08:00
- nfs_ganesha_stable | bool
"when" keyword should precede "block" keyword Otherwise the reader is forced to search for "when" when blocks are too long. Signed-off-by: Rishabh Dave <ridave@redhat.com>
2019-03-28 16:13:30 +08:00
- ceph_repository == 'community'
use blocks directives to group tasks Using block directives simplifies the playbooks and makes them more readable. Fixes: https://github.com/ceph/ceph-ansible/issues/2835 Signed-off-by: Rishabh Dave <ridave@redhat.com>
2018-09-07 20:45:43 +08:00
block:
- name: add nfs-ganesha stable repository
apt_repository:
Use ansible_facts It has come to our attention that using ansible_* vars that are populated with INJECT_FACTS_AS_VARS=True is not very performant. In order to be able to support setting that to off, we need to update the references to use ansible_facts[<thing>] instead of ansible_<thing>. Related: ansible#73654 Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1935406 Signed-off-by: Alex Schultz <aschultz@redhat.com> (cherry picked from commit a7f2fa73e63e69dba2e41aaac9732397eec437c9)
2021-03-03 22:43:50 +08:00
repo: "deb {{ nfs_ganesha_stable_deb_repo }} {{ ceph_stable_distro_source | default(ansible_facts['distribution_release']) }} main"
use blocks directives to group tasks Using block directives simplifies the playbooks and makes them more readable. Fixes: https://github.com/ceph/ceph-ansible/issues/2835 Signed-off-by: Rishabh Dave <ridave@redhat.com>
2018-09-07 20:45:43 +08:00
state: present
update_cache: no
register: add_ganesha_apt_repo
- name: update apt cache
apt:
update_cache: yes
register: update_ganesha_apt_cache
retries: 5
delay: 2
Ansible tests are not filters The use of "| success" and "| changed" are not valid syntax for modern ansible releases. Signed-off-by: Jonathan Rosser <jonathan.rosser@rd.bbc.co.uk>
2020-06-18 20:39:26 +08:00
until: update_ganesha_apt_cache is success
when: add_ganesha_apt_repo is changed
use blocks directives to group tasks Using block directives simplifies the playbooks and makes them more readable. Fixes: https://github.com/ceph/ceph-ansible/issues/2835 Signed-off-by: Rishabh Dave <ridave@redhat.com>
2018-09-07 20:45:43 +08:00
- name: debian based systems - dev repos specific tasks
"when" keyword should precede "block" keyword Otherwise the reader is forced to search for "when" when blocks are too long. Signed-off-by: Rishabh Dave <ridave@redhat.com>
2019-03-28 16:13:30 +08:00
when:
ansible: use 'bool' filter on boolean conditionals By running ceph-ansible there are a lot ``[DEPRECATION WARNING]`` like these: ``` [DEPRECATION WARNING]: evaluating containerized_deployment as a bare variable, this behaviour will go away and you might need to add |bool to the expression in the future. Also see CONDITIONAL_BARE_VARS configuration toggle.. This feature will be removed in version 2.12. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg. ``` Now appended ``| bool`` on a lot of the affected variables. Sometimes the coding style from ``variable|bool`` changed to ``variable | bool`` *(with spaces at the pipe)*. Closes: #4022 Signed-off-by: L3D <l3d@c3woc.de>
2019-05-22 16:02:42 +08:00
- nfs_ganesha_dev | bool
"when" keyword should precede "block" keyword Otherwise the reader is forced to search for "when" when blocks are too long. Signed-off-by: Rishabh Dave <ridave@redhat.com>
2019-03-28 16:13:30 +08:00
- ceph_repository == 'dev'
use blocks directives to group tasks Using block directives simplifies the playbooks and makes them more readable. Fixes: https://github.com/ceph/ceph-ansible/issues/2835 Signed-off-by: Rishabh Dave <ridave@redhat.com>
2018-09-07 20:45:43 +08:00
block:
- name: fetch nfs-ganesha development repository
uri:
Use ansible_facts It has come to our attention that using ansible_* vars that are populated with INJECT_FACTS_AS_VARS=True is not very performant. In order to be able to support setting that to off, we need to update the references to use ansible_facts[<thing>] instead of ansible_<thing>. Related: ansible#73654 Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1935406 Signed-off-by: Alex Schultz <aschultz@redhat.com> (cherry picked from commit a7f2fa73e63e69dba2e41aaac9732397eec437c9)
2021-03-03 22:43:50 +08:00
url: https://shaman.ceph.com/api/repos/nfs-ganesha/next/latest/{{ ansible_facts['distribution'] | lower }}/{{ ansible_facts['distribution_release'] }}/flavors/{{ nfs_ganesha_flavor }}/repo
use blocks directives to group tasks Using block directives simplifies the playbooks and makes them more readable. Fixes: https://github.com/ceph/ceph-ansible/issues/2835 Signed-off-by: Rishabh Dave <ridave@redhat.com>
2018-09-07 20:45:43 +08:00
return_content: yes
nfs-ganesha: fixed nfs_ganesha_dev_apt_repo variable The nfs_ganesha_dev_apt_repo variable was set incorrect in task "fetch nfs-ganesha development repository" Signed-off-by: Bruceforce <Bruceforce@users.noreply.github.com>
2019-01-03 23:08:58 +08:00
register: nfs_ganesha_dev_apt_repo
use blocks directives to group tasks Using block directives simplifies the playbooks and makes them more readable. Fixes: https://github.com/ceph/ceph-ansible/issues/2835 Signed-off-by: Rishabh Dave <ridave@redhat.com>
2018-09-07 20:45:43 +08:00
- name: add nfs-ganesha development repository
copy:
content: "{{ nfs_ganesha_dev_apt_repo.content }}"
dest: /etc/apt/sources.list.d/nfs-ganesha-dev.list
owner: root
group: root
backup: yes
- name: debain based systems - install required packages
block:
- name: debian based systems- non-rhcs installation
"when" keyword should precede "block" keyword Otherwise the reader is forced to search for "when" when blocks are too long. Signed-off-by: Rishabh Dave <ridave@redhat.com>
2019-03-28 16:13:30 +08:00
when:
- (ceph_origin == 'repository' or ceph_origin == 'distro')
- ceph_repository != 'rhcs'
use blocks directives to group tasks Using block directives simplifies the playbooks and makes them more readable. Fixes: https://github.com/ceph/ceph-ansible/issues/2835 Signed-off-by: Rishabh Dave <ridave@redhat.com>
2018-09-07 20:45:43 +08:00
block:
- name: install nfs rgw/cephfs gateway - debian
apt:
pass the list of packages to package management modules Instead of looping over a list of packages or repeating the task separately for different packages, pass the list of packages to the task performing package management. Signed-off-by: Rishabh Dave <ridave@redhat.com>
2018-11-08 17:26:58 +08:00
name: ['nfs-ganesha-rgw', 'radosgw']
use blocks directives to group tasks Using block directives simplifies the playbooks and makes them more readable. Fixes: https://github.com/ceph/ceph-ansible/issues/2835 Signed-off-by: Rishabh Dave <ridave@redhat.com>
2018-09-07 20:45:43 +08:00
allow_unauthenticated: yes
retry on packages and repositories failures add register/until on all packaging related tasks to avoid non valid CI failure. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2018-12-19 21:55:01 +08:00
register: result
until: result is succeeded
ansible: use 'bool' filter on boolean conditionals By running ceph-ansible there are a lot ``[DEPRECATION WARNING]`` like these: ``` [DEPRECATION WARNING]: evaluating containerized_deployment as a bare variable, this behaviour will go away and you might need to add |bool to the expression in the future. Also see CONDITIONAL_BARE_VARS configuration toggle.. This feature will be removed in version 2.12. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg. ``` Now appended ``| bool`` on a lot of the affected variables. Sometimes the coding style from ``variable|bool`` changed to ``variable | bool`` *(with spaces at the pipe)*. Closes: #4022 Signed-off-by: L3D <l3d@c3woc.de>
2019-05-22 16:02:42 +08:00
when: nfs_obj_gw | bool
pass the list of packages to package management modules Instead of looping over a list of packages or repeating the task separately for different packages, pass the list of packages to the task performing package management. Signed-off-by: Rishabh Dave <ridave@redhat.com>
2018-11-08 17:26:58 +08:00
- name: install nfs rgw/cephfs gateway - debian
apt:
name: nfs-ganesha-ceph
allow_unauthenticated: yes
retry on packages and repositories failures add register/until on all packaging related tasks to avoid non valid CI failure. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2018-12-19 21:55:01 +08:00
register: result
until: result is succeeded
ansible: use 'bool' filter on boolean conditionals By running ceph-ansible there are a lot ``[DEPRECATION WARNING]`` like these: ``` [DEPRECATION WARNING]: evaluating containerized_deployment as a bare variable, this behaviour will go away and you might need to add |bool to the expression in the future. Also see CONDITIONAL_BARE_VARS configuration toggle.. This feature will be removed in version 2.12. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg. ``` Now appended ``| bool`` on a lot of the affected variables. Sometimes the coding style from ``variable|bool`` changed to ``variable | bool`` *(with spaces at the pipe)*. Closes: #4022 Signed-off-by: L3D <l3d@c3woc.de>
2019-05-22 16:02:42 +08:00
when: nfs_file_gw | bool
use blocks directives to group tasks Using block directives simplifies the playbooks and makes them more readable. Fixes: https://github.com/ceph/ceph-ansible/issues/2835 Signed-off-by: Rishabh Dave <ridave@redhat.com>
2018-09-07 20:45:43 +08:00
- name: debian based systems - rhcs installation
"when" keyword should precede "block" keyword Otherwise the reader is forced to search for "when" when blocks are too long. Signed-off-by: Rishabh Dave <ridave@redhat.com>
2019-03-28 16:13:30 +08:00
when:
- (ceph_origin == 'repository' or ceph_origin == 'distro')
- ceph_repository == 'rhcs'
use blocks directives to group tasks Using block directives simplifies the playbooks and makes them more readable. Fixes: https://github.com/ceph/ceph-ansible/issues/2835 Signed-off-by: Rishabh Dave <ridave@redhat.com>
2018-09-07 20:45:43 +08:00
block:
- name: install red hat storage nfs gateway for debian
apt:
name: nfs-ganesha
state: "{{ (upgrade_ceph_packages|bool) | ternary('latest','present') }}"
retry on packages and repositories failures add register/until on all packaging related tasks to avoid non valid CI failure. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2018-12-19 21:55:01 +08:00
register: result
until: result is succeeded
use blocks directives to group tasks Using block directives simplifies the playbooks and makes them more readable. Fixes: https://github.com/ceph/ceph-ansible/issues/2835 Signed-off-by: Rishabh Dave <ridave@redhat.com>
2018-09-07 20:45:43 +08:00
- name: install red hat storage nfs file gateway
apt:
name: nfs-ganesha-ceph
state: "{{ (upgrade_ceph_packages|bool) | ternary('latest','present') }}"
retry on packages and repositories failures add register/until on all packaging related tasks to avoid non valid CI failure. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2018-12-19 21:55:01 +08:00
register: result
until: result is succeeded
ansible: use 'bool' filter on boolean conditionals By running ceph-ansible there are a lot ``[DEPRECATION WARNING]`` like these: ``` [DEPRECATION WARNING]: evaluating containerized_deployment as a bare variable, this behaviour will go away and you might need to add |bool to the expression in the future. Also see CONDITIONAL_BARE_VARS configuration toggle.. This feature will be removed in version 2.12. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg. ``` Now appended ``| bool`` on a lot of the affected variables. Sometimes the coding style from ``variable|bool`` changed to ``variable | bool`` *(with spaces at the pipe)*. Closes: #4022 Signed-off-by: L3D <l3d@c3woc.de>
2019-05-22 16:02:42 +08:00
when: nfs_file_gw | bool
use blocks directives to group tasks Using block directives simplifies the playbooks and makes them more readable. Fixes: https://github.com/ceph/ceph-ansible/issues/2835 Signed-off-by: Rishabh Dave <ridave@redhat.com>
2018-09-07 20:45:43 +08:00
- name: install red hat storage nfs obj gateway
apt:
name: nfs-ganesha-rgw
state: "{{ (upgrade_ceph_packages|bool) | ternary('latest','present') }}"
retry on packages and repositories failures add register/until on all packaging related tasks to avoid non valid CI failure. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2018-12-19 21:55:01 +08:00
register: result
until: result is succeeded
ansible: use 'bool' filter on boolean conditionals By running ceph-ansible there are a lot ``[DEPRECATION WARNING]`` like these: ``` [DEPRECATION WARNING]: evaluating containerized_deployment as a bare variable, this behaviour will go away and you might need to add |bool to the expression in the future. Also see CONDITIONAL_BARE_VARS configuration toggle.. This feature will be removed in version 2.12. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg. ``` Now appended ``| bool`` on a lot of the affected variables. Sometimes the coding style from ``variable|bool`` changed to ``variable | bool`` *(with spaces at the pipe)*. Closes: #4022 Signed-off-by: L3D <l3d@c3woc.de>
2019-05-22 16:02:42 +08:00
when: nfs_obj_gw | bool