ceph
/
ceph-ansible
mirror of https://github.com/ceph/ceph-ansible.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
ceph-ansible/roles/ceph-osd/tasks/crush_rules.yml

61 lines
2.9 KiB
YAML
Raw Normal View History

Create OpenStack pools with crush rule Add an extra variable to the openstack pools, which creates them with defined rules. This will allow to place different pools on e.g. different type of disks. This commit will also set a new default rule when defined and move the rbd pool to the new rule.
2017-06-12 16:36:29 +08:00
---
mon: use ceph_crush module in the playbook Instead of creating the CRUSH hierarchy with Ansible tasks using the command module we now rely on the ceph_crush module. Signed-off-by: Sébastien Han <seb@redhat.com>
2018-02-21 22:20:24 +08:00
- name: configure crush hierarchy
ceph_crush:
cluster: "{{ cluster }}"
move crush rule creation from mon to osd role If we want to create crush rules with the create-replicated sub command and device class then we need to have the OSD created before the crush rules otherwise the device classes won't exist. Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
2019-11-01 04:17:33 +08:00
location: "{{ osd_crush_location }}"
containerized: "{{ hostvars[groups[mon_group_name][0]]['container_exec_cmd'] | default('') }}"
mon: fix osd_pool_default_crush_rule persistence and effectiveness Running the last portion (insert new default and add new default crush tasks) of crush_rules.yml only on the last monitor is wrong since ceph CLI calls usually end up on the master having the quorum, which is by default the one with the lower IP. So if we run the command and end up on another mon the creation will happen on the default crush rule because the particular mon hasn't been updated. To fix this we remove the |last on the include and use run_once: true on certain tasks, then we let the final two tasks run on all the monitors. Signed-off-by: Sébastien Han <seb@redhat.com>
2018-03-02 22:50:01 +08:00
register: config_crush_hierarchy
move crush rule creation from mon to osd role If we want to create crush rules with the create-replicated sub command and device class then we need to have the OSD created before the crush rules otherwise the device classes won't exist. Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
2019-11-01 04:17:33 +08:00
delegate_to: '{{ groups[mon_group_name][0] }}'
mon: use ceph_crush module in the playbook Instead of creating the CRUSH hierarchy with Ansible tasks using the command module we now rely on the ceph_crush module. Signed-off-by: Sébastien Han <seb@redhat.com>
2018-02-21 22:20:24 +08:00
when:
ceph-{mon,osd}: move default crush variables Since ed36a11 we move the crush rules creation code from the ceph-mon to the ceph-osd role. To keep the backward compatibility we kept the possibility to set the crush variables on the mons side but we didn't move the default values. As a result, when using crush_rule_config set to true and wanted to use the default values for crush_rules then the crush rule ansible task creation will fail. "msg": "'ansible.vars.hostvars.HostVarsVars object' has no attribute 'crush_rules'" This patch move the default crush variables from ceph-mon to ceph-osd role but also use those default values when nothing is defined on the mons side. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1798864 Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
2020-02-11 02:43:31 +08:00
- hostvars[groups[mon_group_name][0]]['create_crush_tree'] | default(create_crush_tree) | bool
move crush rule creation from mon to osd role If we want to create crush rules with the create-replicated sub command and device class then we need to have the OSD created before the crush rules otherwise the device classes won't exist. Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
2019-11-01 04:17:33 +08:00
- osd_crush_location is defined
Create OpenStack pools with crush rule Add an extra variable to the openstack pools, which creates them with defined rules. This will allow to place different pools on e.g. different type of disks. This commit will also set a new default rule when defined and move the rbd pool to the new rule.
2017-06-12 16:36:29 +08:00
- name: create configured crush rules
ceph-osd: add device class to crush rules This adds device class support to crush rules when using the class key in the rule dict via the create-replicated sub command. If the class key isn't specified then we use the create-simple sub command for backward compatibility. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1636508 Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
2019-11-01 04:24:12 +08:00
command: "{{ hostvars[groups[mon_group_name][0]]['container_exec_cmd'] | default('') }} ceph --cluster {{ cluster }} osd crush rule {{ 'create-replicated' if item.class is defined else 'create-simple' }} {{ item.name }} {{ item.root }} {{ item.type }} {{ item.class | default('') }}"
Create OpenStack pools with crush rule Add an extra variable to the openstack pools, which creates them with defined rules. This will allow to place different pools on e.g. different type of disks. This commit will also set a new default rule when defined and move the rbd pool to the new rule.
2017-06-12 16:36:29 +08:00
changed_when: false
ceph-{mon,osd}: move default crush variables Since ed36a11 we move the crush rules creation code from the ceph-mon to the ceph-osd role. To keep the backward compatibility we kept the possibility to set the crush variables on the mons side but we didn't move the default values. As a result, when using crush_rule_config set to true and wanted to use the default values for crush_rules then the crush rule ansible task creation will fail. "msg": "'ansible.vars.hostvars.HostVarsVars object' has no attribute 'crush_rules'" This patch move the default crush variables from ceph-mon to ceph-osd role but also use those default values when nothing is defined on the mons side. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1798864 Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
2020-02-11 02:43:31 +08:00
with_items: "{{ hostvars[groups[mon_group_name][0]]['crush_rules'] | default(crush_rules) | unique }}"
move crush rule creation from mon to osd role If we want to create crush rules with the create-replicated sub command and device class then we need to have the OSD created before the crush rules otherwise the device classes won't exist. Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
2019-11-01 04:17:33 +08:00
delegate_to: '{{ groups[mon_group_name][0] }}'
run_once: true
Create OpenStack pools with crush rule Add an extra variable to the openstack pools, which creates them with defined rules. This will allow to place different pools on e.g. different type of disks. This commit will also set a new default rule when defined and move the rbd pool to the new rule.
2017-06-12 16:36:29 +08:00
- name: get id for new default crush rule
move crush rule creation from mon to osd role If we want to create crush rules with the create-replicated sub command and device class then we need to have the OSD created before the crush rules otherwise the device classes won't exist. Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
2019-11-01 04:17:33 +08:00
command: "{{ hostvars[groups[mon_group_name][0]]['container_exec_cmd'] | default('') }} ceph --cluster {{ cluster }} osd -f json crush rule dump {{ item.name }}"
Create OpenStack pools with crush rule Add an extra variable to the openstack pools, which creates them with defined rules. This will allow to place different pools on e.g. different type of disks. This commit will also set a new default rule when defined and move the rbd pool to the new rule.
2017-06-12 16:36:29 +08:00
register: info_ceph_default_crush_rule
changed_when: false
ceph-{mon,osd}: move default crush variables Since ed36a11 we move the crush rules creation code from the ceph-mon to the ceph-osd role. To keep the backward compatibility we kept the possibility to set the crush variables on the mons side but we didn't move the default values. As a result, when using crush_rule_config set to true and wanted to use the default values for crush_rules then the crush rule ansible task creation will fail. "msg": "'ansible.vars.hostvars.HostVarsVars object' has no attribute 'crush_rules'" This patch move the default crush variables from ceph-mon to ceph-osd role but also use those default values when nothing is defined on the mons side. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1798864 Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
2020-02-11 02:43:31 +08:00
with_items: "{{ hostvars[groups[mon_group_name][0]]['crush_rules'] | default(crush_rules) | unique }}"
move crush rule creation from mon to osd role If we want to create crush rules with the create-replicated sub command and device class then we need to have the OSD created before the crush rules otherwise the device classes won't exist. Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
2019-11-01 04:17:33 +08:00
delegate_to: '{{ groups[mon_group_name][0] }}'
run_once: true
when: item.default | bool
Create OpenStack pools with crush rule Add an extra variable to the openstack pools, which creates them with defined rules. This will allow to place different pools on e.g. different type of disks. This commit will also set a new default rule when defined and move the rbd pool to the new rule.
2017-06-12 16:36:29 +08:00
mons: Current crush_rule playbook does not work if there is no default rule defined (default: true). One could want to add new crush rules while keeping his current default rule. Fixed it so that it works with all rules defined as "default: false". If multiple rules are defined as default (should not be) then the last rule listed in "crush_rules" is taken as default.
2018-02-07 02:44:03 +08:00
# If multiple rules are set as default (should not be) then the last one is taken as actual default.
mon: fix osd_pool_default_crush_rule persistence and effectiveness Running the last portion (insert new default and add new default crush tasks) of crush_rules.yml only on the last monitor is wrong since ceph CLI calls usually end up on the master having the quorum, which is by default the one with the lower IP. So if we run the command and end up on another mon the creation will happen on the default crush rule because the particular mon hasn't been updated. To fix this we remove the |last on the include and use run_once: true on certain tasks, then we let the final two tasks run on all the monitors. Signed-off-by: Sébastien Han <seb@redhat.com>
2018-03-02 22:50:01 +08:00
# the with_items statement overrides each iteration with the new one.
mon: use ceph_crush module in the playbook Instead of creating the CRUSH hierarchy with Ansible tasks using the command module we now rely on the ceph_crush module. Signed-off-by: Sébastien Han <seb@redhat.com>
2018-02-21 22:20:24 +08:00
# NOTE(leseb): we should actually fail if multiple rules are set as default
name includes and set_fact for clarity When Ansible is not run with verbose options it's difficult to see which include and/or set_fact does what. So adding a name for each clarifies. Signed-off-by: Sébastien Han <seb@redhat.com>
2017-09-15 06:48:53 +08:00
- name: set_fact info_ceph_default_crush_rule_yaml
Create OpenStack pools with crush rule Add an extra variable to the openstack pools, which creates them with defined rules. This will allow to place different pools on e.g. different type of disks. This commit will also set a new default rule when defined and move the rbd pool to the new rule.
2017-06-12 16:36:29 +08:00
set_fact:
mon: fix osd_pool_default_crush_rule persistence and effectiveness Running the last portion (insert new default and add new default crush tasks) of crush_rules.yml only on the last monitor is wrong since ceph CLI calls usually end up on the master having the quorum, which is by default the one with the lower IP. So if we run the command and end up on another mon the creation will happen on the default crush rule because the particular mon hasn't been updated. To fix this we remove the |last on the include and use run_once: true on certain tasks, then we let the final two tasks run on all the monitors. Signed-off-by: Sébastien Han <seb@redhat.com>
2018-03-02 22:50:01 +08:00
info_ceph_default_crush_rule_yaml: "{{ item.stdout | from_json() }}"
mons: Current crush_rule playbook does not work if there is no default rule defined (default: true). One could want to add new crush rules while keeping his current default rule. Fixed it so that it works with all rules defined as "default: false". If multiple rules are defined as default (should not be) then the last rule listed in "crush_rules" is taken as default.
2018-02-07 02:44:03 +08:00
with_items: "{{ info_ceph_default_crush_rule.results }}"
move crush rule creation from mon to osd role If we want to create crush rules with the create-replicated sub command and device class then we need to have the OSD created before the crush rules otherwise the device classes won't exist. Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
2019-11-01 04:17:33 +08:00
run_once: true
when: not item.get('skipped', false)
Create OpenStack pools with crush rule Add an extra variable to the openstack pools, which creates them with defined rules. This will allow to place different pools on e.g. different type of disks. This commit will also set a new default rule when defined and move the rbd pool to the new rule.
2017-06-12 16:36:29 +08:00
- name: insert new default crush rule into daemon to prevent restart
ceph-mon: use --admin-daemon to set default crush rule Signed-off-by: Mihai Plasoianu <m.plasoianu@vertical.de>
2019-10-28 23:30:39 +08:00
command: "{{ hostvars[item]['container_exec_cmd'] | default('') }} ceph --admin-daemon /var/run/ceph/{{ cluster }}-mon.{{ hostvars[item]['monitor_name'] }}.asok config set osd_pool_default_crush_rule {{ info_ceph_default_crush_rule_yaml.rule_id }}"
Create OpenStack pools with crush rule Add an extra variable to the openstack pools, which creates them with defined rules. This will allow to place different pools on e.g. different type of disks. This commit will also set a new default rule when defined and move the rbd pool to the new rule.
2017-06-12 16:36:29 +08:00
changed_when: false
mon: fix osd_pool_default_crush_rule persistence and effectiveness Running the last portion (insert new default and add new default crush tasks) of crush_rules.yml only on the last monitor is wrong since ceph CLI calls usually end up on the master having the quorum, which is by default the one with the lower IP. So if we run the command and end up on another mon the creation will happen on the default crush rule because the particular mon hasn't been updated. To fix this we remove the |last on the include and use run_once: true on certain tasks, then we let the final two tasks run on all the monitors. Signed-off-by: Sébastien Han <seb@redhat.com>
2018-03-02 22:50:01 +08:00
delegate_to: "{{ item }}"
with_items: "{{ groups[mon_group_name] }}"
move crush rule creation from mon to osd role If we want to create crush rules with the create-replicated sub command and device class then we need to have the OSD created before the crush rules otherwise the device classes won't exist. Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
2019-11-01 04:17:33 +08:00
run_once: true
mon: fix set crush default rule On releases after jewel the option 'osd_pool_default_crush_replicated_ruleset' does not exist anymore, it's called osd_pool_default_crush_rule. Signed-off-by: Sébastien Han <seb@redhat.com>
2018-03-02 21:53:57 +08:00
when:
mon: fix osd_pool_default_crush_rule persistence and effectiveness Running the last portion (insert new default and add new default crush tasks) of crush_rules.yml only on the last monitor is wrong since ceph CLI calls usually end up on the master having the quorum, which is by default the one with the lower IP. So if we run the command and end up on another mon the creation will happen on the default crush rule because the particular mon hasn't been updated. To fix this we remove the |last on the include and use run_once: true on certain tasks, then we let the final two tasks run on all the monitors. Signed-off-by: Sébastien Han <seb@redhat.com>
2018-03-02 22:50:01 +08:00
- not config_crush_hierarchy.get('skipped', false)
- info_ceph_default_crush_rule_yaml | default('') | length > 0
Create OpenStack pools with crush rule Add an extra variable to the openstack pools, which creates them with defined rules. This will allow to place different pools on e.g. different type of disks. This commit will also set a new default rule when defined and move the rbd pool to the new rule.
2017-06-12 16:36:29 +08:00
mon: fix set crush default rule On releases after jewel the option 'osd_pool_default_crush_replicated_ruleset' does not exist anymore, it's called osd_pool_default_crush_rule. Signed-off-by: Sébastien Han <seb@redhat.com>
2018-03-02 21:53:57 +08:00
- name: "add new default crush rule to {{ cluster }}.conf"
Create OpenStack pools with crush rule Add an extra variable to the openstack pools, which creates them with defined rules. This will allow to place different pools on e.g. different type of disks. This commit will also set a new default rule when defined and move the rbd pool to the new rule.
2017-06-12 16:36:29 +08:00
ini_file:
dest: "/etc/ceph/{{ cluster }}.conf"
section: "global"
Set the default crush rule in ceph.conf Currently the default crush rule value is added to the ceph config on the mon nodes as an extra configuration applied after the template generation via the ansible ini module. This implies two behaviors: 1/ On each ceph-ansible run, the ceph.conf will be regenerated via ceph-config+template and then ceph-mon+ini_file. This leads to a non necessary daemons restart. 2/ When other ceph daemons are collocated on the monitor nodes (like mgr or rgw), the default crush rule value will be erased by the ceph.conf template (mon -> mgr -> rgw). This patch adds the osd_pool_default_crush_rule config to the ceph template and only for the monitor nodes (like crush_rules.yml). The default crush rule id is read (if exist) from the current ceph configuration. The default configuration is -1 (ceph default). Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1638092 Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
2019-03-08 06:14:12 +08:00
option: "osd pool default crush rule"
Create OpenStack pools with crush rule Add an extra variable to the openstack pools, which creates them with defined rules. This will allow to place different pools on e.g. different type of disks. This commit will also set a new default rule when defined and move the rbd pool to the new rule.
2017-06-12 16:36:29 +08:00
value: "{{ info_ceph_default_crush_rule_yaml.rule_id }}"
mon: fix osd_pool_default_crush_rule persistence and effectiveness Running the last portion (insert new default and add new default crush tasks) of crush_rules.yml only on the last monitor is wrong since ceph CLI calls usually end up on the master having the quorum, which is by default the one with the lower IP. So if we run the command and end up on another mon the creation will happen on the default crush rule because the particular mon hasn't been updated. To fix this we remove the |last on the include and use run_once: true on certain tasks, then we let the final two tasks run on all the monitors. Signed-off-by: Sébastien Han <seb@redhat.com>
2018-03-02 22:50:01 +08:00
delegate_to: "{{ item }}"
with_items: "{{ groups[mon_group_name] }}"
move crush rule creation from mon to osd role If we want to create crush rules with the create-replicated sub command and device class then we need to have the OSD created before the crush rules otherwise the device classes won't exist. Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
2019-11-01 04:17:33 +08:00
run_once: true
mon: fix osd_pool_default_crush_rule persistence and effectiveness Running the last portion (insert new default and add new default crush tasks) of crush_rules.yml only on the last monitor is wrong since ceph CLI calls usually end up on the master having the quorum, which is by default the one with the lower IP. So if we run the command and end up on another mon the creation will happen on the default crush rule because the particular mon hasn't been updated. To fix this we remove the |last on the include and use run_once: true on certain tasks, then we let the final two tasks run on all the monitors. Signed-off-by: Sébastien Han <seb@redhat.com>
2018-03-02 22:50:01 +08:00
when:
- not config_crush_hierarchy.get('skipped', false)
- info_ceph_default_crush_rule_yaml | default('') | length > 0