From 25ac0efddd8352e0821fd2368b2c4277d9728ba1 Mon Sep 17 00:00:00 2001 From: Dimitri Savineau Date: Thu, 14 Nov 2019 09:29:29 -0500 Subject: [PATCH] container: add always tag on gather fact tasks If we execute the site-container.yml playbook with specific tags (like ceph_update_config) then we need to be sure to gather the facts otherwise we will see error like: The task includes an option with an undefined variable. The error was: 'ansible_hostname' is undefined This commit also adds missing 'gather_facts: false' to mons plays. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1754432 Signed-off-by: Dimitri Savineau (cherry picked from commit d7fd769b6ddcb63086cc414e00cce31433d56673) --- site-docker.yml.sample | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/site-docker.yml.sample b/site-docker.yml.sample index 1ab2328cd..7ade7d3dc 100644 --- a/site-docker.yml.sample +++ b/site-docker.yml.sample @@ -24,8 +24,8 @@ pre_tasks: - name: gather facts setup: - when: - - not delegate_facts_host | bool + when: not delegate_facts_host | bool + tags: always - name: gather and delegate facts setup: @@ -33,21 +33,19 @@ delegate_facts: True with_items: "{{ groups['all'] }}" run_once: true - when: - - delegate_facts_host | bool + when: delegate_facts_host | bool + tags: always - name: check if it is atomic host stat: path: /run/ostree-booted register: stat_ostree - tags: - - always + tags: always - name: set_fact is_atomic set_fact: is_atomic: '{{ stat_ostree.stat.exists }}' - tags: - - always + tags: always roles: - role: ceph-defaults @@ -74,6 +72,7 @@ - hosts: mons any_errors_fatal: true + gather_facts: false tasks: - name: set ceph monitor install 'In Progress' run_once: true @@ -102,6 +101,7 @@ - hosts: mons any_errors_fatal: true + gather_facts: false tasks: - name: set ceph monitor install 'Complete' run_once: true