From 28009496f60fed9fc9123b691c62ba4d2b3e31d1 Mon Sep 17 00:00:00 2001 From: Dimitri Savineau Date: Mon, 9 Sep 2019 11:23:47 -0400 Subject: [PATCH] ceph-handler: Fix osd restart condition In containerized deployment, the restart OSD handler couldn't be triggered in most ansible execution. This is due to the usage of run_once + a condition on the inventory hostname and the last filter. The run_once is triggered first so ansible will pick a node in the osd group to execute the restart task. But if this node isn't the last one in the osd group then the task is ignored. There's more probability that the task will be ignored than executed. Signed-off-by: Dimitri Savineau (cherry picked from commit 5b1c15653fcb4772f0839f3a57f7e36ba1b86f49) --- roles/ceph-handler/handlers/main.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/roles/ceph-handler/handlers/main.yml b/roles/ceph-handler/handlers/main.yml index 95132e6cb..72ee60462 100644 --- a/roles/ceph-handler/handlers/main.yml +++ b/roles/ceph-handler/handlers/main.yml @@ -105,7 +105,6 @@ - osd_group_name in group_names - containerized_deployment - not rolling_update - - inventory_hostname == groups.get(osd_group_name) | last - ceph_osd_container_stat.get('rc') == 0 - ceph_osd_container_stat.get('stdout_lines', [])|length != 0 - handler_health_osd_check