From 44e3195ded3ce52b1d4eab0497f67dc4e9322096 Mon Sep 17 00:00:00 2001
From: Guillaume Abrioux <gabrioux@redhat.com>
Date: Mon, 17 Aug 2020 10:31:11 +0200
Subject: [PATCH] facts: refact and optimize memory consumption

there's no need to run this task on all nodes.
This uses too much memory for nothing.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1856981

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit f0fe193d8ec48414447aa4a7d50b1a9859c71295)
---
 roles/ceph-facts/tasks/facts.yml | 87 ++++++++++++++++++--------------
 1 file changed, 50 insertions(+), 37 deletions(-)

diff --git a/roles/ceph-facts/tasks/facts.yml b/roles/ceph-facts/tasks/facts.yml
index 19fa21d8b..f67bbe46a 100644
--- a/roles/ceph-facts/tasks/facts.yml
+++ b/roles/ceph-facts/tasks/facts.yml
@@ -121,12 +121,12 @@
     # this task shouldn't run in a rolling_update situation
     # because it blindly picks a mon, which may be down because
     # of the rolling update
-    - name: is ceph running already?
-      command: "{{ timeout_command }} {{ _container_exec_cmd | default('') }} ceph --cluster {{ cluster }} -s -f json"
+    - name: get current fsid if cluster is already running
+      command: "{{ timeout_command }} {{ _container_exec_cmd | default('') }} ceph --cluster {{ cluster }} fsid"
       changed_when: false
       failed_when: false
       check_mode: no
-      register: ceph_current_status
+      register: current_fsid
       run_once: true
       delegate_to: "{{ groups[mon_group_name][0] if running_mon is undefined else running_mon }}"
       when:
@@ -134,9 +134,9 @@
 
 # set this as a default when performing a rolling_update
 # so the rest of the tasks here will succeed
-- name: set_fact ceph_current_status rc 1
+- name: set_fact current_fsid rc 1
   set_fact:
-    ceph_current_status:
+    current_fsid:
       rc: 1
   when: rolling_update or groups.get(mon_group_name, []) | length == 0
 
@@ -165,33 +165,27 @@
     - rolling_update | bool
     - groups.get(mon_group_name, []) | length > 0
 
-- name: set_fact ceph_current_status (convert to json)
+- name: set_fact fsid from current_fsid
   set_fact:
-    ceph_current_status: "{{ ceph_current_status.stdout | from_json }}"
-  when:
-    - not rolling_update | bool
-    - ceph_current_status.rc == 0
-
-- name: set_fact fsid from ceph_current_status
-  set_fact:
-    fsid: "{{ ceph_current_status.fsid }}"
-  when: ceph_current_status.fsid is defined
+    fsid: "{{ current_fsid.stdout }}"
+  run_once: true
+  when: current_fsid.rc == 0
 
 - name: fsid related tasks
   when:
     - generate_fsid | bool
-    - ceph_current_status.fsid is undefined
+    - current_fsid.rc != 0
     - not rolling_update | bool
   block:
-  - name: generate cluster fsid
-    command: "{{ hostvars[groups[mon_group_name][0]]['discovered_interpreter_python'] }} -c 'import uuid; print(str(uuid.uuid4()))'"
-    register: cluster_uuid
-    delegate_to: "{{ groups[mon_group_name][0] }}"
-    run_once: true
+    - name: generate cluster fsid
+      command: "{{ hostvars[groups[mon_group_name][0]]['discovered_interpreter_python'] }} -c 'import uuid; print(str(uuid.uuid4()))'"
+      register: cluster_uuid
+      delegate_to: "{{ groups[mon_group_name][0] }}"
+      run_once: true
 
-  - name: set_fact fsid
-    set_fact:
-      fsid: "{{ cluster_uuid.stdout }}"
+    - name: set_fact fsid
+      set_fact:
+        fsid: "{{ cluster_uuid.stdout }}"
 
 - name: set_fact mds_name ansible_hostname
   set_fact:
@@ -294,20 +288,39 @@
       or ceph_docker_image_tag | string is search("rhceph")
       or (ansible_distribution == 'RedHat'))
 
-- name: set_fact rgw_hostname
-  set_fact:
-    rgw_hostname: "{% set _value = ansible_hostname -%}
-    {% for key in (ceph_current_status['servicemap']['services']['rgw']['daemons'] | list) -%}
-    {% if key == ansible_fqdn -%}
-    {% set _value = key -%}
-    {% endif -%}
-    {% endfor -%}
-    {{ _value }}"
+- name: backward compatibility tasks related
   when:
-    - inventory_hostname in groups.get(rgw_group_name, []) or inventory_hostname in groups.get(nfs_group_name, [])
-    - ceph_current_status['servicemap'] is defined
-    - ceph_current_status['servicemap']['services'] is defined
-    - ceph_current_status['servicemap']['services']['rgw'] is defined
+    - inventory_hostname in groups.get(rgw_group_name, [])
+      or inventory_hostname in groups.get(nfs_group_name, [])
+  block:
+    - name: get ceph current status
+      command: "{{ timeout_command }} {{ _container_exec_cmd | default('') }} ceph --cluster {{ cluster }} -s -f json"
+      changed_when: false
+      failed_when: false
+      check_mode: no
+      register: ceph_current_status
+      run_once: true
+      delegate_to: "{{ groups[mon_group_name][0] if running_mon is undefined else running_mon }}"
+
+    - name: set_fact ceph_current_status
+      set_fact:
+        ceph_current_status: "{{ ceph_current_status.stdout | from_json }}"
+      run_once: true
+      when: ceph_current_status.rc == 0
+
+    - name: set_fact rgw_hostname
+      set_fact:
+        rgw_hostname: "{% set _value = ansible_hostname -%}
+        {% for key in (ceph_current_status['servicemap']['services']['rgw']['daemons'] | list) -%}
+        {% if key == ansible_fqdn -%}
+        {% set _value = key -%}
+        {% endif -%}
+        {% endfor -%}
+        {{ _value }}"
+      when:
+        - ceph_current_status['servicemap'] is defined
+        - ceph_current_status['servicemap']['services'] is defined
+        - ceph_current_status['servicemap']['services']['rgw'] is defined
 
 - name: set_fact osd_pool_default_pg_num
   set_fact: