From 46fe58ec5e98a0e959571f8a0dff0651a5ef2f8f Mon Sep 17 00:00:00 2001 From: Seena Fallah Date: Sat, 16 Mar 2024 16:15:13 +0100 Subject: [PATCH] radosgw_user: parse system and admin as boolean The returned payload from rgw has them as a boolean. By having them as a string it would always report a change and try to modify the user. Signed-off-by: Seena Fallah (cherry picked from commit a95726c40900d30bb3728fc99e7487c65ea2d0a1) --- library/radosgw_user.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/library/radosgw_user.py b/library/radosgw_user.py index 8e26bbb3b..fddbf893b 100644 --- a/library/radosgw_user.py +++ b/library/radosgw_user.py @@ -415,8 +415,8 @@ def run_module(): email = module.params.get('email') access_key = module.params.get('access_key') secret_key = module.params.get('secret_key') - system = str(module.params.get('system')).lower() - admin = str(module.params.get('admin')).lower() + system = module.params.get('system') + admin = module.params.get('admin') if module.check_mode: module.exit_json( @@ -441,8 +441,8 @@ def run_module(): user = json.loads(out) current = { 'display_name': user['display_name'], - 'system': user.get('system', 'false'), - 'admin': user.get('admin', 'false') + 'system': user.get('system', False), + 'admin': user.get('admin', False) } asked = { 'display_name': display_name,