From 53793b352e31bfc9ee3c0f9dd6c55254c50d46d3 Mon Sep 17 00:00:00 2001 From: Guillaume Abrioux Date: Wed, 22 Jul 2020 01:51:20 +0200 Subject: [PATCH] tests: (lvm_setup.yml), don't shrink lvol when rerunning lvm_setup.yml on existing cluster with OSDs already deployed, it fails like following: ``` fatal: [osd0]: FAILED! => changed=false msg: Sorry, no shrinking of data-lv2 to 0 permitted. ``` because we are asking `lvol` module to create a volume on an empty VG with size extents = `100%FREE`. The default behavior of `lvol` is to shrink the volume if the LV's current size is greater than the requested size. Given the requested size is calculated like this: `size_requested = size_percent * this_vg['free'] / 100` in our case, it is similar to: `size_requested = 100 * 0 / 100` which basically means `0` So the current LV size is well greater than the requested size which leads the module to attempt to shrink it to 0 which isn't obviously now allowed. Adding `shrink: false` to the module calls fixes this issue. Signed-off-by: Guillaume Abrioux (cherry picked from commit 218f4ae361b53fd7632d17495ba54fb6e2afed10) --- tests/functional/lvm_setup.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/functional/lvm_setup.yml b/tests/functional/lvm_setup.yml index 35aeb6889..15b23bafa 100644 --- a/tests/functional/lvm_setup.yml +++ b/tests/functional/lvm_setup.yml @@ -35,11 +35,13 @@ vg: test_group lv: data-lv1 size: 50%FREE + shrink: false - name: create logical volume 2 lvol: vg: test_group lv: data-lv2 size: 100%FREE + shrink: false - name: partition "{{ pv_devices[1] | default('/dev/sdc') }}"for journals parted: device: "{{ pv_devices[1] | default('/dev/sdc') }}" @@ -69,3 +71,4 @@ vg: journals lv: journal1 size: 100%FREE + shrink: false