From 57b0890aff91412fbdccbe0ec250ec06f4015f80 Mon Sep 17 00:00:00 2001 From: Seena Fallah Date: Sat, 24 Sep 2022 19:21:41 +0200 Subject: [PATCH] ceph-config: don't check for devices on existing osds When osd_auto_discovery is true the `devices` var will be empty (as the disks have holders). Also in general there is no need to check for devices to list the devices with ceph-volume as we have `default({})` on the stdout in `num_osds` set fact in the next task Signed-off-by: Seena Fallah --- roles/ceph-config/tasks/main.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/roles/ceph-config/tasks/main.yml b/roles/ceph-config/tasks/main.yml index 796a80f23..fc9a90e2b 100644 --- a/roles/ceph-config/tasks/main.yml +++ b/roles/ceph-config/tasks/main.yml @@ -89,14 +89,10 @@ CEPH_CONTAINER_BINARY: "{{ container_binary }}" PYTHONIOENCODING: utf-8 changed_when: false - when: - - devices | default([]) | length > 0 - name: set_fact num_osds (add existing osds) set_fact: num_osds: "{{ lvm_list.stdout | default('{}') | from_json | length | int + num_osds | default(0) | int }}" - when: - - devices | default([]) | length > 0 - name: set osd related config facts when: inventory_hostname in groups.get(osd_group_name, [])