From 732e5b10b8f9566ed7876564b2152d1df5b4ed40 Mon Sep 17 00:00:00 2001 From: Guillaume Abrioux Date: Fri, 12 Mar 2021 09:26:16 +0100 Subject: [PATCH] update: convert legacy grafana-server groupname early If the legacy name `grafana-server` is still being used when upgrading from Nautilus to Pacific, the task that sets the fact `rolling_update` to `true` doesn't run on the node(s) included in that group. Indeed the play where we set this fact (`rolling_update`) only runs on the group `monitoring_group_name | default('monitoring')`. As a workaround, we can run earlier the task which converts the `grafana-server` group name to `monitoring`. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1935554 Signed-off-by: Guillaume Abrioux (cherry picked from commit 6ccc8b472223b08cad748856f0ef7b08da3f6622) --- infrastructure-playbooks/rolling_update.yml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/infrastructure-playbooks/rolling_update.yml b/infrastructure-playbooks/rolling_update.yml index 96440f0f9..36002f164 100644 --- a/infrastructure-playbooks/rolling_update.yml +++ b/infrastructure-playbooks/rolling_update.yml @@ -36,6 +36,16 @@ invoking the playbook" when: ireallymeanit != 'yes' + - name: import_role ceph-defaults + import_role: + name: ceph-defaults + + - name: check if a legacy grafana-server group exists + import_role: + name: ceph-facts + tasks_from: convert_grafana_server_group_name.yml + when: groups.get((grafana_server_group_name | default('grafana-server')), []) | length > 0 + - name: gather facts and check the init system