From 8a653cacd56553926126d0b43d328af94bbd0337 Mon Sep 17 00:00:00 2001 From: Guillaume Abrioux Date: Thu, 7 Jun 2018 15:49:03 +0200 Subject: [PATCH] client: add a default value for keyring file Potential error if someone doesnt pass the mode in `keys` dict for client nodes: ``` fatal: [client2]: FAILED! => {} MSG: The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'mode' The error appears to have been in '/home/guits/ceph-ansible/roles/ceph-client/tasks/create_users_keys.yml': line 117, column 3, but may be elsewhere in the file depending on the exact syntax problem. The offending line appears to be: - name: get client cephx keys ^ here exception type: exception: 'dict object' has no attribute 'mode' ``` adding a default value will avoid the deployment failing for this. Signed-off-by: Guillaume Abrioux --- roles/ceph-client/tasks/create_users_keys.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roles/ceph-client/tasks/create_users_keys.yml b/roles/ceph-client/tasks/create_users_keys.yml index abb3cf0b4..a0d10ce70 100644 --- a/roles/ceph-client/tasks/create_users_keys.yml +++ b/roles/ceph-client/tasks/create_users_keys.yml @@ -118,7 +118,7 @@ copy: dest: "{{ item.source }}" content: "{{ item.content | b64decode }}" - mode: "{{ item.item.mode }}" + mode: "{{ item.item.get('mode', '0600') }}" owner: "{{ ceph_uid }}" group: "{{ ceph_uid }}" with_items: