From 4531b67a4fc6acd7f29ce966f52e4cea48cadb0b Mon Sep 17 00:00:00 2001
From: Michael Sambol <sambol.michael@gmail.com>
Date: Wed, 5 Aug 2015 23:06:09 -0500
Subject: [PATCH] Use stat module instead of shell

---
 cluster-os-migration.yml            |  8 ++++----
 roles/ceph-common/handlers/main.yml | 18 +++++++++---------
 roles/ceph-common/tasks/main.yml    |  4 ++--
 rolling_update.yml                  |  8 ++++----
 4 files changed, 19 insertions(+), 19 deletions(-)

diff --git a/cluster-os-migration.yml b/cluster-os-migration.yml
index 9053dfd91..e828288b3 100644
--- a/cluster-os-migration.yml
+++ b/cluster-os-migration.yml
@@ -284,13 +284,13 @@
       when: migration_completed.stat.exists == False
 
     - name: Check if sysvinit
-      shell: stat /var/lib/ceph/osd/ceph-*/sysvinit
+      stat: path=/var/lib/ceph/osd/ceph-*/sysvinit
       register: osdsysvinit
       failed_when: false
       changed_when: False
 
     - name: Check if upstart
-      shell: stat /var/lib/ceph/osd/ceph-*/upstart
+      stat: path=/var/lib/ceph/osd/ceph-*/upstart
       register: osdupstart
       failed_when: false
       changed_when: False
@@ -329,14 +329,14 @@
       service: >
         name=ceph-osd-all
         state=stopped
-      when: osdupstart.rc == 0 and migration_completed.stat.exists == False
+      when: osdupstart.stat.exists and migration_completed.stat.exists == False
 
     - name: Gracefully stop the OSDs (Sysvinit)
       service: >
         name=ceph
         state=stopped
         args=mon
-      when: osdsysvinit.rc == 0 and migration_completed.stat.exists == False
+      when: osdsysvinit.stat.exists and migration_completed.stat.exists == False
 
     - name: Wait for the OSDs to be down
       local_action: >
diff --git a/roles/ceph-common/handlers/main.yml b/roles/ceph-common/handlers/main.yml
index f2c54aa82..d719803f7 100644
--- a/roles/ceph-common/handlers/main.yml
+++ b/roles/ceph-common/handlers/main.yml
@@ -5,63 +5,63 @@
 - name: restart ceph mons
   command: service ceph restart mon
   when:
-    socket.rc == 0 and
+    socket.stat.exists and
     ansible_distribution != 'Ubuntu' and
     mon_group_name in group_names
 
 - name: restart ceph mons on ubuntu
   command: restart ceph-mon-all
   when:
-    socket.rc == 0 and
+    socket.stat.exists and
     ansible_distribution == 'Ubuntu' and
     mon_group_name in group_names
 
 - name: restart ceph osds
   command: service ceph restart osd
   when:
-    socket.rc == 0 and
+    socket.stat.exists and
     ansible_distribution != 'Ubuntu' and
     osd_group_name in group_names
 
 - name: restart ceph osds on ubuntu
   command: restart ceph-osd-all
   when:
-    socket.rc == 0 and
+    socket.stat.exists and
     ansible_distribution == 'Ubuntu' and
     osd_group_name in group_names
 
 - name: restart ceph mdss on ubuntu
   command: restart ceph-mds-all
   when:
-    socket.rc == 0 and
+    socket.stat.exists and
     ansible_distribution == 'Ubuntu' and
     mds_group_name in group_names
 
 - name: restart ceph mdss
   command: service ceph restart mds
   when:
-    socket.rc == 0 and
+    socket.stat.exists and
     ansible_distribution != 'Ubuntu' and
     mds_group_name in group_names
 
 - name: restart ceph rgws on ubuntu
   command: restart ceph-all
   when:
-    socketrgw.rc == 0 and
+    socketrgw.stat.exists and
     ansible_distribution == 'Ubuntu' and
     rgw_group_name in group_names
 
 - name: restart ceph rgws
   command: /etc/init.d/radosgw restart
   when:
-    socketrgw.rc == 0 and
+    socketrgw.stat.exists and
     ansible_distribution != 'Ubuntu' and
     rgw_group_name in group_names
 
 - name: restart ceph rgws on red hat
   command: /etc/init.d/ceph-radosgw restart
   when:
-    socketrgw.rc == 0 and
+    socketrgw.stat.exists and
     ansible_os_family == 'RedHat' and
     rgw_group_name in group_names
 
diff --git a/roles/ceph-common/tasks/main.yml b/roles/ceph-common/tasks/main.yml
index 3d46fa337..373700bd0 100644
--- a/roles/ceph-common/tasks/main.yml
+++ b/roles/ceph-common/tasks/main.yml
@@ -38,13 +38,13 @@
     rgw_group_name in group_names
 
 - name: check for a ceph socket
-  shell: "stat /var/run/ceph/*.asok > /dev/null 2>&1"
+  stat: path=/var/run/ceph/*.asok
   changed_when: false
   failed_when: false
   register: socket
 
 - name: check for a rados gateway socket
-  shell: "stat {{ rbd_client_admin_socket_path }}*.asok > /dev/null 2>&1"
+  stat: path={{ rbd_client_admin_socket_path }}*.asok
   changed_when: false
   failed_when: false
   register: socketrgw
diff --git a/rolling_update.yml b/rolling_update.yml
index eb9c12792..80a9c38f4 100644
--- a/rolling_update.yml
+++ b/rolling_update.yml
@@ -90,12 +90,12 @@
 
   post_tasks:
     - name: Check if sysvinit
-      shell: stat /var/lib/ceph/osd/ceph-*/sysvinit
+      stat: path=/var/lib/ceph/osd/ceph-*/sysvinit
       register: osdsysvinit
       failed_when: false
 
     - name: Check if upstart
-      shell: stat /var/lib/ceph/osd/ceph-*/upstart
+      stat: path=/var/lib/ceph/osd/ceph-*/upstart
       register: osdupstart
       failed_when: false
 
@@ -103,14 +103,14 @@
       service: >
         name=ceph-osd-all
         state=restarted
-      when: osdupstart.rc == 0
+      when: osdupstart.stat.exists
 
     - name: Gracefully stop the OSDs (Sysvinit)
       service: >
         name=ceph
         state=restarted
         args=osd
-      when: osdsysvinit.rc == 0
+      when: osdsysvinit.stat.exists
 
     - name: Waiting for clean PGs...
       shell: >