From a9247c4de78dec8a63f17400deb8b06ce91e7267 Mon Sep 17 00:00:00 2001
From: Guillaume Abrioux <gabrioux@redhat.com>
Date: Wed, 16 May 2018 17:34:38 +0200
Subject: [PATCH] purge_cluster: wipe all partitions

In order to ensure there is no leftover after having purged a cluster,
we must wipe all partitions properly.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1492242

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
---
 infrastructure-playbooks/purge-cluster.yml | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/infrastructure-playbooks/purge-cluster.yml b/infrastructure-playbooks/purge-cluster.yml
index 71979471b..bcba8b05a 100644
--- a/infrastructure-playbooks/purge-cluster.yml
+++ b/infrastructure-playbooks/purge-cluster.yml
@@ -388,17 +388,25 @@
     set_fact:
       resolved_parent_device: "{{ tmp_resolved_parent_device.results | map(attribute='stdout') | list | unique }}"
 
+  - name: wipe partitions
+    shell: |
+      wipefs --all "{{ item }}"
+      dd if=/dev/zero of="{{ item }}" bs=1 count=4096
+    with_items: "{{ combined_devices_list }}"
+
   - name: zap ceph journal/block db/block wal partitions
     shell: |
       # if the disk passed is a raw device AND the boot system disk
-      if parted -s "/dev/{{ item }}" print | grep -sq boot; then
+      if parted -s /dev/"{{ item }}" print | grep -sq boot; then
         echo "Looks like /dev/{{ item }} has a boot partition,"
         echo "if you want to delete specific partitions point to the partition instead of the raw device"
         echo "Do not use your system disk!"
         exit 1
       fi
-      sgdisk -Z "/dev/{{ item }}"
-      dd if=/dev/zero of="/dev/{{ item }}" bs=1M count=200
+      sgdisk -Z --clear --mbrtogpt -g -- /dev/"{{ item }}"
+      dd if=/dev/zero of=/dev/"{{ item }}" bs=1M count=200
+      parted -s /dev/"{{ item }}" mklabel gpt
+      partprobe /dev/"{{ item }}"
       udevadm settle --timeout=600
     with_items:
       - "{{ resolved_parent_device }}"