From a952122c38e88736b7459c30390165cac4a0148c Mon Sep 17 00:00:00 2001 From: Guillaume Abrioux Date: Thu, 29 Nov 2018 16:04:28 +0100 Subject: [PATCH] rolling_update: create missing keyring only on running mon try to create the potentially missing keys only on monitors that are actually running. The current node being played is stopped before this task. By the way, delegating the command on all nodes but the current node being played ensures that the generated keys will be present on all monitors. Signed-off-by: Guillaume Abrioux --- infrastructure-playbooks/rolling_update.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/infrastructure-playbooks/rolling_update.yml b/infrastructure-playbooks/rolling_update.yml index 3f0e8cb1f..c7f408d85 100644 --- a/infrastructure-playbooks/rolling_update.yml +++ b/infrastructure-playbooks/rolling_update.yml @@ -197,14 +197,14 @@ caps: mon: "allow profile {{ item.0 }}" cluster: "{{ cluster }}" - containerized: "{{ 'docker exec ceph-mon-' + hostvars[mon_host]['ansible_hostname'] if containerized_deployment else None }}" + containerized: "{{ 'docker exec ceph-mon-' + hostvars[item.1]['ansible_hostname'] if containerized_deployment else None }}" when: - cephx - delegate_to: "{{ mon_host }}" + delegate_to: "{{ item.1 }}" ignore_errors: True # this might fail for upgrade from J to L on rbd-mirror and also on partially updated clusters with_nested: - ['bootstrap-rbd', 'bootstrap-rbd-mirror'] - - "{{ groups[mon_group_name] }}" # so the key goes on all the nodes + - "{{ groups[mon_group_name] | difference([mon_host]) }}" # so the key goes on all the nodes - name: set osd flags command: ceph --cluster {{ cluster }} osd set {{ item }}