From c60a7ad4f60eeef33892cb624aff88e2e1ecfeae Mon Sep 17 00:00:00 2001
From: Guillaume Abrioux <gabrioux@redhat.com>
Date: Tue, 15 Sep 2020 09:48:31 +0200
Subject: [PATCH] infra: support log rotation for tcmu-runner

This commit adds the log rotation support for tcmu-runner.

ceph-container related PR: ceph/ceph-container#1726

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1873915

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit f576c02ff7b15c207b77b3f206a3213184b89889)
---
 roles/ceph-infra/templates/logrotate.conf.j2        | 13 +++++++++++++
 roles/ceph-iscsi-gw/tasks/containerized.yml         |  1 +
 .../ceph-iscsi-gw/templates/tcmu-runner.service.j2  |  2 +-
 3 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/roles/ceph-infra/templates/logrotate.conf.j2 b/roles/ceph-infra/templates/logrotate.conf.j2
index c64d4e03d..c2ed6c025 100644
--- a/roles/ceph-infra/templates/logrotate.conf.j2
+++ b/roles/ceph-infra/templates/logrotate.conf.j2
@@ -10,3 +10,16 @@
     notifempty
     su root root
 }
+
+/var/log/tcmu-runner/*.log {
+    rotate 7
+    daily
+    compress
+    sharedscripts
+    postrotate
+        killall -q -1 tcmu-runner || pkill -1 -x "tcmu-runner"
+    endscript
+    missingok
+    notifempty
+    su root root
+}
diff --git a/roles/ceph-iscsi-gw/tasks/containerized.yml b/roles/ceph-iscsi-gw/tasks/containerized.yml
index b5dc4e95d..bea446ded 100644
--- a/roles/ceph-iscsi-gw/tasks/containerized.yml
+++ b/roles/ceph-iscsi-gw/tasks/containerized.yml
@@ -6,6 +6,7 @@
   with_items:
     - rbd-target-api
     - rbd-target-gw
+    - tcmu-runner
 
 - name: include_tasks systemd.yml
   include_tasks: systemd.yml
diff --git a/roles/ceph-iscsi-gw/templates/tcmu-runner.service.j2 b/roles/ceph-iscsi-gw/templates/tcmu-runner.service.j2
index 66716504a..c498249d0 100644
--- a/roles/ceph-iscsi-gw/templates/tcmu-runner.service.j2
+++ b/roles/ceph-iscsi-gw/templates/tcmu-runner.service.j2
@@ -32,7 +32,7 @@ ExecStart=/usr/bin/{{ container_binary }} run --rm \
   -v /dev:/dev \
   -v /lib/modules:/lib/modules \
   -v /etc/ceph:/etc/ceph \
-  -v /var/log/ceph:/var/log/ceph:z \
+  -v /var/log/tcmu-runner:/var/log/tcmu-runner:z \
   -e CLUSTER={{ cluster }} \
   -e CEPH_DAEMON=TCMU_RUNNER \
   -e CONTAINER_IMAGE={{ ceph_docker_registry }}/{{ ceph_docker_image }}:{{ ceph_docker_image_tag }} \