From d549fffdd24d21661b64b31bda20b4e8c6aa82b6 Mon Sep 17 00:00:00 2001 From: Dimitri Savineau Date: Mon, 22 Jul 2019 16:58:40 -0400 Subject: [PATCH] ceph-osd: check container engine rc for pools When creating OpenStack pools, we only check if the return code from the pool list command isn't 0 (ie: if it doesn't exist). In that case, the return code will be 2. That's why the next condition is rc != 0 for the pool creation. But in containerized deployment, the return code could be different if there's a failure on the container engine command (like container not running). In that case, the return code could but either 1 (docker) or 125 (podman) so we should fail at this point and not in the next tasks. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1732157 Signed-off-by: Dimitri Savineau --- roles/ceph-osd/tasks/openstack_config.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/roles/ceph-osd/tasks/openstack_config.yml b/roles/ceph-osd/tasks/openstack_config.yml index 9a0a8db84..fee91095d 100644 --- a/roles/ceph-osd/tasks/openstack_config.yml +++ b/roles/ceph-osd/tasks/openstack_config.yml @@ -20,7 +20,8 @@ with_items: "{{ openstack_pools | unique }}" register: created_pools delegate_to: "{{ groups[mon_group_name][0] }}" - failed_when: false + failed_when: created_pools.rc in [1, 125] + changed_when: false - name: create openstack pool(s) command: >