From f6c410109b390d77b8f408685e0594db560a4f1f Mon Sep 17 00:00:00 2001
From: Seena Fallah <seenafallah@gmail.com>
Date: Thu, 5 Aug 2021 20:17:10 +0430
Subject: [PATCH] ceph-validate: export validate repository vars as a task

Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit 4f6da9d92ff264e05dbcd7c9d36398acd1692935)
---
 .../ceph-validate/tasks/check_repository.yml  | 20 ++++++++++++++++++
 roles/ceph-validate/tasks/main.yml            | 21 +------------------
 2 files changed, 21 insertions(+), 20 deletions(-)
 create mode 100644 roles/ceph-validate/tasks/check_repository.yml

diff --git a/roles/ceph-validate/tasks/check_repository.yml b/roles/ceph-validate/tasks/check_repository.yml
new file mode 100644
index 000000000..8f0bf1743
--- /dev/null
+++ b/roles/ceph-validate/tasks/check_repository.yml
@@ -0,0 +1,20 @@
+---
+- name: validate ceph_origin
+  fail:
+    msg: "ceph_origin must be either 'repository', 'distro' or 'local'"
+  when: ceph_origin not in ['repository', 'distro', 'local']
+
+- name: validate ceph_repository
+  fail:
+    msg: "ceph_repository must be either 'community', 'rhcs', 'dev', 'custom' or 'uca'"
+  when:
+    - ceph_origin == 'repository'
+    - ceph_repository not in ['community', 'rhcs', 'dev', 'custom', 'uca']
+
+- name: validate ceph_repository_community
+  fail:
+    msg: "ceph_stable_release must be 'pacific'"
+  when:
+    - ceph_origin == 'repository'
+    - ceph_repository == 'community'
+    - ceph_stable_release not in ['pacific']
diff --git a/roles/ceph-validate/tasks/main.yml b/roles/ceph-validate/tasks/main.yml
index 9723a6029..ccbbdfe28 100644
--- a/roles/ceph-validate/tasks/main.yml
+++ b/roles/ceph-validate/tasks/main.yml
@@ -3,27 +3,8 @@
   include_tasks: check_system.yml
 
 - name: validate repository variables in non-containerized scenario
+  include_tasks: check_repository.yml
   when: not containerized_deployment | bool
-  block:
-    - name: validate ceph_origin
-      fail:
-        msg: "ceph_origin must be either 'repository', 'distro' or 'local'"
-      when: ceph_origin not in ['repository', 'distro', 'local']
-
-    - name: validate ceph_repository
-      fail:
-        msg: "ceph_repository must be either 'community', 'rhcs', 'dev', 'custom' or 'uca'"
-      when:
-        - ceph_origin == 'repository'
-        - ceph_repository not in ['community', 'rhcs', 'dev', 'custom', 'uca']
-
-    - name: validate ceph_repository_community
-      fail:
-        msg: "ceph_stable_release must be 'pacific'"
-      when:
-        - ceph_origin == 'repository'
-        - ceph_repository == 'community'
-        - ceph_stable_release != 'pacific'
 
 - name: validate osd_objectstore
   fail: