diff --git a/.gitignore b/.gitignore index 23d4c25bb..cbabf997f 100644 --- a/.gitignore +++ b/.gitignore @@ -21,3 +21,4 @@ ceph-ansible.spec !.mergify.yml !raw_install_python.yml !requirements.yml +.vscode/ diff --git a/group_vars/all.yml.sample b/group_vars/all.yml.sample index 0bd819e74..e534fa962 100644 --- a/group_vars/all.yml.sample +++ b/group_vars/all.yml.sample @@ -368,8 +368,7 @@ dummy: #radosgw_address_block: subnet #radosgw_keystone_ssl: false # activate this when using keystone PKI keys #radosgw_num_instances: 1 -# Rados Gateway options -#email_address: foo@bar.com +#rgw_zone: default # This is used for rgw instance client names. ## Testing mode @@ -445,7 +444,7 @@ dummy: # global: # foo: 1234 # bar: 5678 -# "client.rgw.{{ hostvars[groups.get(rgw_group_name)[0]]['ansible_facts']['hostname'] }}": +# "client.rgw.{{ rgw_zone }}.{{ hostvars[groups.get(rgw_group_name)[0]]['ansible_facts']['hostname'] }}": # rgw_zone: zone1 # #ceph_conf_overrides: {} diff --git a/group_vars/rgws.yml.sample b/group_vars/rgws.yml.sample index 76e57a6e9..5445ec8f2 100644 --- a/group_vars/rgws.yml.sample +++ b/group_vars/rgws.yml.sample @@ -88,11 +88,11 @@ dummy: # If you want to add parameters, you should retain the existing ones and include the new ones. #ceph_rgw_container_params: # volumes: -# - /var/lib/ceph/radosgw/{{ cluster }}-rgw.{{ ansible_facts['hostname'] }}.${INST_NAME}:/var/lib/ceph/radosgw/{{ cluster }}-rgw.{{ ansible_facts['hostname'] }}.${INST_NAME}:z +# - /var/lib/ceph/radosgw/{{ cluster }}-rgw.{{ rgw_zone }}.{{ ansible_facts['hostname'] }}.${INST_NAME}:/var/lib/ceph/radosgw/{{ cluster }}-rgw.{{ rgw_zone }}.{{ ansible_facts['hostname'] }}.${INST_NAME}:z # args: # - -f -# - -n=client.rgw.{{ ansible_facts['hostname'] }}.${INST_NAME} -# - -k=/var/lib/ceph/radosgw/{{ cluster }}-rgw.{{ ansible_facts['hostname'] }}.${INST_NAME}/keyring +# - -n=client.rgw.{{ rgw_zone }}.{{ ansible_facts['hostname'] }}.${INST_NAME} +# - -k=/var/lib/ceph/radosgw/{{ cluster }}-rgw.{{ rgw_zone }}.{{ ansible_facts['hostname'] }}.${INST_NAME}/keyring ########### # SYSTEMD # diff --git a/infrastructure-playbooks/cephadm-adopt.yml b/infrastructure-playbooks/cephadm-adopt.yml index 6ab66358c..3922e0790 100644 --- a/infrastructure-playbooks/cephadm-adopt.yml +++ b/infrastructure-playbooks/cephadm-adopt.yml @@ -961,7 +961,7 @@ - name: Stop and disable ceph-radosgw systemd service ansible.builtin.service: - name: "ceph-radosgw@rgw.{{ ansible_facts['hostname'] }}.{{ item.instance_name }}" + name: "ceph-radosgw@rgw.{{ rgw_zone }}.{{ ansible_facts['hostname'] }}.{{ item.instance_name }}" state: stopped enabled: false failed_when: false @@ -975,7 +975,7 @@ failed_when: false - name: Reset failed ceph-radosgw systemd unit - ansible.builtin.command: "systemctl reset-failed ceph-radosgw@rgw.{{ ansible_facts['hostname'] }}.{{ item.instance_name }}" # noqa command-instead-of-module + ansible.builtin.command: "systemctl reset-failed ceph-radosgw@rgw.{{ rgw_zone }}.{{ ansible_facts['hostname'] }}.{{ item.instance_name }}" # noqa command-instead-of-module changed_when: false failed_when: false loop: '{{ rgw_instances }}' @@ -992,13 +992,13 @@ - name: Remove legacy ceph radosgw data ansible.builtin.file: - path: "/var/lib/ceph/radosgw/{{ cluster }}-rgw.{{ ansible_facts['hostname'] }}.{{ item.instance_name }}" + path: "/var/lib/ceph/radosgw/{{ cluster }}-rgw.{{ rgw_zone }}.{{ ansible_facts['hostname'] }}.{{ item.instance_name }}" state: absent loop: '{{ rgw_instances }}' - name: Remove legacy ceph radosgw directory ansible.builtin.file: - path: "/var/lib/ceph/radosgw/{{ cluster }}-rgw.{{ ansible_facts['hostname'] }}" + path: "/var/lib/ceph/radosgw/{{ cluster }}-rgw.{{ rgw_zone }}.{{ ansible_facts['hostname'] }}" state: absent - name: Redeploy rbd-mirror daemons diff --git a/infrastructure-playbooks/purge-cluster.yml b/infrastructure-playbooks/purge-cluster.yml index 9107658f3..b55e46849 100644 --- a/infrastructure-playbooks/purge-cluster.yml +++ b/infrastructure-playbooks/purge-cluster.yml @@ -259,7 +259,7 @@ - name: Stop ceph rgws with systemd ansible.builtin.service: - name: "ceph-radosgw@rgw.{{ ansible_facts['hostname'] }}.{{ item.instance_name }}" + name: "ceph-radosgw@rgw.{{ rgw_zone }}.{{ ansible_facts['hostname'] }}.{{ item.instance_name }}" state: stopped enabled: false failed_when: false diff --git a/infrastructure-playbooks/rolling_update.yml b/infrastructure-playbooks/rolling_update.yml index ef391f017..21bafa910 100644 --- a/infrastructure-playbooks/rolling_update.yml +++ b/infrastructure-playbooks/rolling_update.yml @@ -940,7 +940,7 @@ - name: Stop ceph rgw when upgrading from stable-3.2 # noqa: ignore-errors ansible.builtin.systemd: - name: ceph-radosgw@rgw.{{ ansible_facts['hostname'] }} + name: ceph-radosgw@rgw.{{ rgw_zone }}.{{ ansible_facts['hostname'] }} state: stopped enabled: false masked: true @@ -948,7 +948,7 @@ - name: Stop ceph rgw ansible.builtin.systemd: - name: ceph-radosgw@rgw.{{ ansible_facts['hostname'] }}.{{ item.instance_name }} + name: ceph-radosgw@rgw.{{ rgw_zone }}.{{ ansible_facts['hostname'] }}.{{ item.instance_name }} state: stopped enabled: false masked: true diff --git a/infrastructure-playbooks/switch-from-non-containerized-to-containerized-ceph-daemons.yml b/infrastructure-playbooks/switch-from-non-containerized-to-containerized-ceph-daemons.yml index 023fd3c09..851618ac0 100644 --- a/infrastructure-playbooks/switch-from-non-containerized-to-containerized-ceph-daemons.yml +++ b/infrastructure-playbooks/switch-from-non-containerized-to-containerized-ceph-daemons.yml @@ -564,7 +564,7 @@ tasks: - name: Stop non-containerized ceph rgw(s) ansible.builtin.service: - name: "ceph-radosgw@rgw.{{ ansible_facts['hostname'] }}.{{ item.instance_name }}" + name: "ceph-radosgw@rgw.{{ rgw_zone }}.{{ ansible_facts['hostname'] }}.{{ item.instance_name }}" state: stopped enabled: false with_items: "{{ rgw_instances }}" diff --git a/profiles/rgw-keystone-v2 b/profiles/rgw-keystone-v2 index 861815a07..05fc81571 100644 --- a/profiles/rgw-keystone-v2 +++ b/profiles/rgw-keystone-v2 @@ -7,7 +7,7 @@ ceph_conf_overrides: - "client.rgw.{{ hostvars[inventory_hostname]['ansible_facts']['hostname'] }}": + "client.rgw.{{ rgw_zone }}.{{ hostvars[inventory_hostname]['ansible_facts']['hostname'] }}": "rgw keystone api version": "2" "rgw keystone url": "http://192.168.0.1:35357" "rgw keystone admin token": "password" diff --git a/profiles/rgw-keystone-v3 b/profiles/rgw-keystone-v3 index ae5e04574..a82d96b68 100644 --- a/profiles/rgw-keystone-v3 +++ b/profiles/rgw-keystone-v3 @@ -7,7 +7,7 @@ ceph_conf_overrides: - "client.rgw.{{ hostvars[inventory_hostname]['ansible_facts']['hostname'] }}": + "client.rgw.{{ rgw_zone }}.{{ hostvars[inventory_hostname]['ansible_facts']['hostname'] }}": "rgw keystone api version": "3" "rgw keystone url": "http://192.168.0.1:35357" "rgw keystone admin token": "password" diff --git a/profiles/rgw-radosgw-static-website b/profiles/rgw-radosgw-static-website index 1cd18c260..fc1ff890e 100644 --- a/profiles/rgw-radosgw-static-website +++ b/profiles/rgw-radosgw-static-website @@ -6,6 +6,6 @@ # The double quotes are important, do NOT remove them. ceph_conf_overrides: - "client.rgw.{{ hostvars[inventory_hostname]['ansible_facts']['hostname'] }}": + "client.rgw.{{ rgw_zone }}.{{ hostvars[inventory_hostname]['ansible_facts']['hostname'] }}": rgw enable static website = true rgw dns s3website name = objects-website-region.domain.com diff --git a/profiles/rgw-usage-log b/profiles/rgw-usage-log index af704fb72..2f0a6021d 100644 --- a/profiles/rgw-usage-log +++ b/profiles/rgw-usage-log @@ -6,7 +6,7 @@ # The double quotes are important, do NOT remove them. ceph_conf_overrides: - "client.rgw.{{ hostvars[inventory_hostname]['ansible_facts']['hostname'] }}": + "client.rgw.{{ rgw_zone }}.{{ hostvars[inventory_hostname]['ansible_facts']['hostname'] }}": rgw enable usage log = true rgw usage log tick interval = 30 rgw usage log flush threshold = 1024 diff --git a/roles/ceph-config/tasks/main.yml b/roles/ceph-config/tasks/main.yml index acfee21d1..3dad8af7a 100644 --- a/roles/ceph-config/tasks/main.yml +++ b/roles/ceph-config/tasks/main.yml @@ -131,8 +131,8 @@ ansible.builtin.set_fact: _ceph_ansible_rgw_conf: >- {{ _ceph_ansible_rgw_conf | default({}) | combine({ - 'client.rgw.' + ansible_facts['hostname'] + '.' + item.instance_name: { - 'log_file': '/var/log/ceph/' + cluster + '-rgw-' + ansible_facts['hostname'] + '.' + item.instance_name + '.log', + 'client.rgw.' + rgw_zone + '.' + ansible_facts['hostname'] + '.' + item.instance_name: { + 'log_file': '/var/log/ceph/' + cluster + '-rgw-' + rgw_zone + '-' + ansible_facts['hostname'] + '.' + item.instance_name + '.log', 'rgw_frontends': 'beast ' + _rgw_beast_endpoint + _rgw_beast_ssl_option, } }, recursive=true) }} diff --git a/roles/ceph-config/tasks/rgw_systemd_environment_file.yml b/roles/ceph-config/tasks/rgw_systemd_environment_file.yml index 5876738ad..df52e6abc 100644 --- a/roles/ceph-config/tasks/rgw_systemd_environment_file.yml +++ b/roles/ceph-config/tasks/rgw_systemd_environment_file.yml @@ -1,7 +1,7 @@ --- - name: Create rados gateway instance directories ansible.builtin.file: - path: "/var/lib/ceph/radosgw/{{ cluster }}-rgw.{{ ansible_facts['hostname'] }}.{{ item.instance_name }}" + path: "/var/lib/ceph/radosgw/{{ cluster }}-rgw.{{ rgw_zone }}.{{ ansible_facts['hostname'] }}.{{ item.instance_name }}" state: directory owner: "{{ ceph_uid if containerized_deployment | bool else 'ceph' }}" group: "{{ ceph_uid if containerized_deployment | bool else 'ceph' }}" @@ -10,7 +10,7 @@ - name: Generate environment file ansible.builtin.copy: - dest: "/var/lib/ceph/radosgw/{{ cluster }}-rgw.{{ ansible_facts['hostname'] }}.{{ item.instance_name }}/EnvironmentFile" + dest: "/var/lib/ceph/radosgw/{{ cluster }}-rgw.{{ rgw_zone }}.{{ ansible_facts['hostname'] }}.{{ item.instance_name }}/EnvironmentFile" owner: "root" group: "root" mode: "0644" diff --git a/roles/ceph-defaults/defaults/main.yml b/roles/ceph-defaults/defaults/main.yml index 107b0b7bc..ffb6abfe6 100644 --- a/roles/ceph-defaults/defaults/main.yml +++ b/roles/ceph-defaults/defaults/main.yml @@ -360,8 +360,7 @@ radosgw_address: x.x.x.x radosgw_address_block: subnet radosgw_keystone_ssl: false # activate this when using keystone PKI keys radosgw_num_instances: 1 -# Rados Gateway options -email_address: foo@bar.com +rgw_zone: default # This is used for rgw instance client names. ## Testing mode @@ -437,7 +436,7 @@ ceph_rbd_mirror_pool: "rbd" # global: # foo: 1234 # bar: 5678 -# "client.rgw.{{ hostvars[groups.get(rgw_group_name)[0]]['ansible_facts']['hostname'] }}": +# "client.rgw.{{ rgw_zone }}.{{ hostvars[groups.get(rgw_group_name)[0]]['ansible_facts']['hostname'] }}": # rgw_zone: zone1 # ceph_conf_overrides: {} diff --git a/roles/ceph-handler/tasks/check_running_containers.yml b/roles/ceph-handler/tasks/check_running_containers.yml index 0c006b886..2f6a40ff5 100644 --- a/roles/ceph-handler/tasks/check_running_containers.yml +++ b/roles/ceph-handler/tasks/check_running_containers.yml @@ -24,7 +24,7 @@ when: inventory_hostname in groups.get(mds_group_name, []) - name: Check for a rgw container - ansible.builtin.command: "{{ container_binary }} ps -q --filter='name=ceph-rgw-{{ ansible_facts['hostname'] }}'" + ansible.builtin.command: "{{ container_binary }} ps -q --filter='name=ceph-rgw-{{ rgw_zone }}-{{ ansible_facts['hostname'] }}'" register: ceph_rgw_container_stat changed_when: false failed_when: false diff --git a/roles/ceph-handler/templates/restart_rgw_daemon.sh.j2 b/roles/ceph-handler/templates/restart_rgw_daemon.sh.j2 index 0c7a8ff0d..5ea0f3c7d 100644 --- a/roles/ceph-handler/templates/restart_rgw_daemon.sh.j2 +++ b/roles/ceph-handler/templates/restart_rgw_daemon.sh.j2 @@ -13,13 +13,14 @@ fi INSTANCES_NAME=({% for i in rgw_instances %}{{ i.instance_name }} {% endfor %}) RGW_IPS=({% for i in rgw_instances %}{{ i.radosgw_address }} {% endfor %}) RGW_PORTS=({% for i in rgw_instances %}{{ i.radosgw_frontend_port }} {% endfor %}) +RGW_ZONE="{{ rgw_zone }}" declare -a DOCKER_EXECS declare -a SOCKET_PREFIX for ((i=0; i<${RGW_NUMS}; i++)); do - SOCKET_PREFIX[i]="/var/run/ceph/{{ cluster }}-client.rgw.${HOST_NAME}.${INSTANCES_NAME[i]}" + SOCKET_PREFIX[i]="/var/run/ceph/{{ cluster }}-client.rgw.${RGW_ZONE}.${HOST_NAME}.${INSTANCES_NAME[i]}" DOCKER_EXECS[i]="" {% if containerized_deployment | bool %} - DOCKER_EXECS[i]="{{ container_binary }} exec ceph-rgw-${HOST_NAME}-${INSTANCES_NAME[i]}" + DOCKER_EXECS[i]="{{ container_binary }} exec ceph-rgw-${RGW_ZONE}-${HOST_NAME}-${INSTANCES_NAME[i]}" {% endif %} done @@ -38,7 +39,7 @@ check_socket() { done if [ $succ -ne 1 ]; then echo "Socket file ${SOCKET} could not be found, which means Rados Gateway is not running. Showing ceph-rgw unit logs now:" - journalctl -u ceph-radosgw@rgw.${HOST_NAME}.${INSTANCES_NAME[i]} + journalctl -u ceph-radosgw@rgw.${RGW_ZONE}.${HOST_NAME}.${INSTANCES_NAME[i]} exit 1 fi } @@ -81,10 +82,10 @@ for ((i=0; i<${RGW_NUMS}; i++)); do # Check if systemd unit exists # This is needed for new instances as the restart might trigger before the deployment - if systemctl list-units --full --all | grep -q "ceph-radosgw@rgw.${HOST_NAME}.${INSTANCES_NAME[i]}"; then - systemctl restart ceph-radosgw@rgw.${HOST_NAME}.${INSTANCES_NAME[i]} + if systemctl list-units --full --all | grep -q "ceph-radosgw@rgw.${RGW_ZONE}.${HOST_NAME}.${INSTANCES_NAME[i]}"; then + systemctl restart ceph-radosgw@rgw.${RGW_ZONE}.${HOST_NAME}.${INSTANCES_NAME[i]} else - echo "Systemd unit ceph-radosgw@rgw.${HOST_NAME}.${INSTANCES_NAME[i]} does not exist." + echo "Systemd unit ceph-radosgw@rgw.${RGW_ZONE}.${HOST_NAME}.${INSTANCES_NAME[i]} does not exist." continue fi diff --git a/roles/ceph-rgw/defaults/main.yml b/roles/ceph-rgw/defaults/main.yml index c53edd5c9..4e16074ff 100644 --- a/roles/ceph-rgw/defaults/main.yml +++ b/roles/ceph-rgw/defaults/main.yml @@ -80,11 +80,11 @@ rgw_config_keys: "/" # DON'T TOUCH ME # If you want to add parameters, you should retain the existing ones and include the new ones. ceph_rgw_container_params: volumes: - - /var/lib/ceph/radosgw/{{ cluster }}-rgw.{{ ansible_facts['hostname'] }}.${INST_NAME}:/var/lib/ceph/radosgw/{{ cluster }}-rgw.{{ ansible_facts['hostname'] }}.${INST_NAME}:z + - /var/lib/ceph/radosgw/{{ cluster }}-rgw.{{ rgw_zone }}.{{ ansible_facts['hostname'] }}.${INST_NAME}:/var/lib/ceph/radosgw/{{ cluster }}-rgw.{{ rgw_zone }}.{{ ansible_facts['hostname'] }}.${INST_NAME}:z args: - -f - - -n=client.rgw.{{ ansible_facts['hostname'] }}.${INST_NAME} - - -k=/var/lib/ceph/radosgw/{{ cluster }}-rgw.{{ ansible_facts['hostname'] }}.${INST_NAME}/keyring + - -n=client.rgw.{{ rgw_zone }}.{{ ansible_facts['hostname'] }}.${INST_NAME} + - -k=/var/lib/ceph/radosgw/{{ cluster }}-rgw.{{ rgw_zone }}.{{ ansible_facts['hostname'] }}.${INST_NAME}/keyring ########### # SYSTEMD # diff --git a/roles/ceph-rgw/handlers/main.yml b/roles/ceph-rgw/handlers/main.yml index a0344c7fa..54d24b781 100644 --- a/roles/ceph-rgw/handlers/main.yml +++ b/roles/ceph-rgw/handlers/main.yml @@ -1,6 +1,6 @@ --- - name: Restart rgw ansible.builtin.service: - name: "ceph-radosgw@rgw.{{ ansible_facts['hostname'] }}.{{ item.instance_name }}" + name: "ceph-radosgw@rgw.{{ rgw_zone }}.{{ ansible_facts['hostname'] }}.{{ item.instance_name }}" state: restarted with_items: "{{ rgw_instances }}" diff --git a/roles/ceph-rgw/tasks/common.yml b/roles/ceph-rgw/tasks/common.yml index 3b2604d3c..225f9ecae 100644 --- a/roles/ceph-rgw/tasks/common.yml +++ b/roles/ceph-rgw/tasks/common.yml @@ -1,13 +1,4 @@ --- -- name: Create rados gateway directories - ansible.builtin.file: - path: "{{ item }}" - state: directory - owner: "{{ ceph_uid if containerized_deployment | bool else 'ceph' }}" - group: "{{ ceph_uid if containerized_deployment | bool else 'ceph' }}" - mode: "{{ ceph_directories_mode }}" - with_items: "{{ rbd_client_admin_socket_path }}" - - name: Get keys from monitors ceph_key: name: "{{ item.name }}" diff --git a/roles/ceph-rgw/tasks/pre_requisite.yml b/roles/ceph-rgw/tasks/pre_requisite.yml index a31b88dfb..2f374cb07 100644 --- a/roles/ceph-rgw/tasks/pre_requisite.yml +++ b/roles/ceph-rgw/tasks/pre_requisite.yml @@ -1,7 +1,7 @@ --- - name: Create rados gateway directories ansible.builtin.file: - path: "/var/lib/ceph/radosgw/{{ cluster }}-rgw.{{ ansible_facts['hostname'] }}.{{ item.instance_name }}" + path: "/var/lib/ceph/radosgw/{{ cluster }}-rgw.{{ rgw_zone }}.{{ ansible_facts['hostname'] }}.{{ item.instance_name }}" state: directory owner: "{{ ceph_uid if containerized_deployment | bool else 'ceph' }}" group: "{{ ceph_uid if containerized_deployment | bool else 'ceph' }}" @@ -12,11 +12,11 @@ - name: Create rgw keyrings ceph_key: - name: "client.rgw.{{ ansible_facts['hostname'] }}.{{ item.instance_name }}" + name: "client.rgw.{{ rgw_zone }}.{{ ansible_facts['hostname'] }}.{{ item.instance_name }}" cluster: "{{ cluster }}" user: "client.bootstrap-rgw" user_key: /var/lib/ceph/bootstrap-rgw/{{ cluster }}.keyring - dest: "/var/lib/ceph/radosgw/{{ cluster }}-rgw.{{ ansible_facts['hostname'] }}.{{ item.instance_name }}/keyring" + dest: "/var/lib/ceph/radosgw/{{ cluster }}-rgw.{{ rgw_zone }}.{{ ansible_facts['hostname'] }}.{{ item.instance_name }}/keyring" caps: osd: 'allow rwx' mon: 'allow rw' @@ -34,7 +34,7 @@ - name: Get keys from monitors ceph_key: - name: "client.rgw.{{ ansible_facts['hostname'] }}.{{ item.instance_name }}" + name: "client.rgw.{{ rgw_zone }}.{{ ansible_facts['hostname'] }}.{{ item.instance_name }}" cluster: "{{ cluster }}" output_format: plain state: info @@ -51,7 +51,7 @@ - name: Copy ceph key(s) if needed ansible.builtin.copy: - dest: "/var/lib/ceph/radosgw/{{ cluster }}-rgw.{{ ansible_facts['hostname'] }}.{{ item.item.instance_name }}/keyring" + dest: "/var/lib/ceph/radosgw/{{ cluster }}-rgw.{{ rgw_zone }}.{{ ansible_facts['hostname'] }}.{{ item.item.instance_name }}/keyring" content: "{{ item.stdout + '\n' }}" owner: "{{ ceph_uid if containerized_deployment | bool else 'ceph' }}" group: "{{ ceph_uid if containerized_deployment | bool else 'ceph' }}" diff --git a/roles/ceph-rgw/tasks/start_docker_rgw.yml b/roles/ceph-rgw/tasks/start_docker_rgw.yml index cffeec811..c9df6c77f 100644 --- a/roles/ceph-rgw/tasks/start_docker_rgw.yml +++ b/roles/ceph-rgw/tasks/start_docker_rgw.yml @@ -4,7 +4,7 @@ - name: Systemd start rgw container ansible.builtin.systemd: - name: ceph-radosgw@rgw.{{ ansible_facts['hostname'] }}.{{ item.instance_name }} + name: ceph-radosgw@rgw.{{ rgw_zone }}.{{ ansible_facts['hostname'] }}.{{ item.instance_name }} state: started enabled: true masked: false diff --git a/roles/ceph-rgw/tasks/start_radosgw.yml b/roles/ceph-rgw/tasks/start_radosgw.yml index 805667548..5de184fb1 100644 --- a/roles/ceph-rgw/tasks/start_radosgw.yml +++ b/roles/ceph-rgw/tasks/start_radosgw.yml @@ -16,7 +16,7 @@ - name: Start rgw instance ansible.builtin.systemd: - name: ceph-radosgw@rgw.{{ ansible_facts['hostname'] }}.{{ item.instance_name }} + name: ceph-radosgw@rgw.{{ rgw_zone }}.{{ ansible_facts['hostname'] }}.{{ item.instance_name }} state: started enabled: true masked: false diff --git a/roles/ceph-rgw/templates/ceph-radosgw.service.j2 b/roles/ceph-rgw/templates/ceph-radosgw.service.j2 index 524817653..38fd96818 100644 --- a/roles/ceph-rgw/templates/ceph-radosgw.service.j2 +++ b/roles/ceph-rgw/templates/ceph-radosgw.service.j2 @@ -14,12 +14,12 @@ Wants=network-online.target local-fs.target time-sync.target EnvironmentFile=/var/lib/ceph/radosgw/{{ cluster }}-%i/EnvironmentFile {% if container_binary == 'podman' %} ExecStartPre=-/usr/bin/rm -f /%t/%n-pid /%t/%n-cid -ExecStartPre=-/usr/bin/{{ container_binary }} rm --storage ceph-rgw-{{ ansible_facts['hostname'] }}-${INST_NAME} +ExecStartPre=-/usr/bin/{{ container_binary }} rm --storage ceph-rgw-{{ rgw_zone }}-{{ ansible_facts['hostname'] }}-${INST_NAME} ExecStartPre=-/usr/bin/mkdir -p /var/log/ceph {% else %} -ExecStartPre=-/usr/bin/{{ container_binary }} stop ceph-rgw-{{ ansible_facts['hostname'] }}-${INST_NAME} +ExecStartPre=-/usr/bin/{{ container_binary }} stop ceph-rgw-{{ rgw_zone }}-{{ ansible_facts['hostname'] }}-${INST_NAME} {% endif %} -ExecStartPre=-/usr/bin/{{ container_binary }} rm ceph-rgw-{{ ansible_facts['hostname'] }}-${INST_NAME} +ExecStartPre=-/usr/bin/{{ container_binary }} rm ceph-rgw-{{ rgw_zone }}-{{ ansible_facts['hostname'] }}-${INST_NAME} ExecStart=/usr/bin/{{ container_binary }} run --rm --net=host \ {% if container_binary == 'podman' %} -d --log-driver journald --conmon-pidfile /%t/%n-pid --cidfile /%t/%n-cid \ @@ -46,14 +46,14 @@ ExecStart=/usr/bin/{{ container_binary }} run --rm --net=host \ {% if radosgw_frontend_ssl_certificate -%} -v {{ radosgw_frontend_ssl_certificate }}:{{ radosgw_frontend_ssl_certificate }} \ {% endif -%} - --name=ceph-rgw-{{ ansible_facts['hostname'] }}-${INST_NAME} \ + --name=ceph-rgw-{{ rgw_zone }}-{{ ansible_facts['hostname'] }}-${INST_NAME} \ --entrypoint=/usr/bin/radosgw \ {{ ceph_docker_registry }}/{{ ceph_docker_image }}:{{ ceph_docker_image_tag }} \ {{ (ceph_common_container_params['args'] + ceph_rgw_container_params['args'] | default([])) | join(' ') }} {% if container_binary == 'podman' %} ExecStop=-/usr/bin/sh -c "/usr/bin/{{ container_binary }} rm -f `cat /%t/%n-cid`" {% else %} -ExecStopPost=-/usr/bin/{{ container_binary }} stop ceph-rgw-{{ ansible_facts['hostname'] }}-${INST_NAME} +ExecStopPost=-/usr/bin/{{ container_binary }} stop ceph-rgw-{{ rgw_zone }}-{{ ansible_facts['hostname'] }}-${INST_NAME} {% endif %} KillMode=none Restart=always diff --git a/tests/functional/collect-logs.yml b/tests/functional/collect-logs.yml index e17a1716d..362ce7be8 100644 --- a/tests/functional/collect-logs.yml +++ b/tests/functional/collect-logs.yml @@ -58,7 +58,7 @@ (groups.get(mgr_group_name, []) | length == 0 and inventory_hostname in groups.get(mon_group_name, [])) - name: Get rgw log - ansible.builtin.shell: journalctl -l -u ceph-radosgw@rgw.{{ ansible_facts['hostname'] }}.{{ item.instance_name }} > /var/log/ceph/ceph-radosgw.{{ ansible_facts['hostname'] }}.{{ item.instance_name }}.log + ansible.builtin.shell: journalctl -l -u ceph-radosgw@rgw.{{ rgw_zone }}.{{ ansible_facts['hostname'] }}.{{ item.instance_name }} > /var/log/ceph/ceph-radosgw.{{ ansible_facts['hostname'] }}.{{ item.instance_name }}.log changed_when: false with_items: "{{ rgw_instances | default([]) }}" when: inventory_hostname in groups.get(rgw_group_name, []) diff --git a/tests/functional/tests/rgw/test_rgw.py b/tests/functional/tests/rgw/test_rgw.py index 8a45be0c7..6d3d15988 100644 --- a/tests/functional/tests/rgw/test_rgw.py +++ b/tests/functional/tests/rgw/test_rgw.py @@ -13,9 +13,10 @@ class TestRGWs(object): def test_rgw_service_enabled_and_running(self, node, host): for i in range(int(node["radosgw_num_instances"])): - service_name = "ceph-radosgw@rgw.{hostname}.rgw{seq}".format( + service_name = "ceph-radosgw@rgw.{rgw_zone}.{hostname}.rgw{seq}".format( hostname=node["vars"]["inventory_hostname"], - seq=i + seq=i, + rgw_zone=node["vars"].get("rgw_zone", "default"), ) s = host.service(service_name) assert s.is_enabled diff --git a/tox.ini b/tox.ini index ee50d47fe..1a1b7f26d 100644 --- a/tox.ini +++ b/tox.ini @@ -62,6 +62,7 @@ commands= # set up the cluster again ansible-playbook -vv --diff -i {changedir}/{env:INVENTORY} {toxinidir}/{env:PLAYBOOK:site.yml.sample} --extra-vars @ceph-override.json --extra-vars "\ + no_log_on_ceph_key_tasks=false \ yes_i_know=true \ ceph_docker_registry_auth=True \ ceph_docker_registry_username={env:DOCKER_HUB_USERNAME} \ @@ -81,6 +82,7 @@ commands= # set up the cluster again ansible-playbook -vv --diff -i {changedir}/{env:INVENTORY} {toxinidir}/{env:PLAYBOOK:site.yml.sample} --extra-vars @ceph-override.json --extra-vars "\ + no_log_on_ceph_key_tasks=false \ yes_i_know=true \ ceph_docker_registry_auth=True \ ceph_docker_registry_username={env:DOCKER_HUB_USERNAME} \ @@ -179,6 +181,7 @@ commands= commands= ansible-playbook -vv --diff -i {changedir}/hosts-2 --limit mgrs {toxinidir}/tests/functional/setup.yml ansible-playbook -vv --diff -i {changedir}/hosts-2 --limit mgrs {toxinidir}/{env:PLAYBOOK:site.yml.sample} --extra-vars "\ + no_log_on_ceph_key_tasks=false \ yes_i_know=true \ ireallymeanit=yes \ ceph_docker_registry_auth=True \ @@ -191,6 +194,7 @@ commands= commands= ansible-playbook -vv --diff -i {changedir}/hosts-2 --limit mdss {toxinidir}/tests/functional/setup.yml ansible-playbook -vv --diff -i {changedir}/hosts-2 --limit mdss {toxinidir}/{env:PLAYBOOK:site.yml.sample} --extra-vars "\ + no_log_on_ceph_key_tasks=false \ yes_i_know=true \ ireallymeanit=yes \ ceph_docker_registry_auth=True \ @@ -203,6 +207,7 @@ commands= commands= ansible-playbook -vv --diff -i {changedir}/hosts-2 --limit rbdmirrors {toxinidir}/tests/functional/setup.yml ansible-playbook -vv --diff -i {changedir}/hosts-2 --limit rbdmirrors {toxinidir}/{env:PLAYBOOK:site.yml.sample} --extra-vars "\ + no_log_on_ceph_key_tasks=false \ yes_i_know=true \ ireallymeanit=yes \ ceph_docker_registry_auth=True \ @@ -215,6 +220,7 @@ commands= commands= ansible-playbook -vv --diff -i {changedir}/hosts-2 --limit rgws {toxinidir}/tests/functional/setup.yml ansible-playbook -vv --diff -i {changedir}/hosts-2 --limit rgws {toxinidir}/{env:PLAYBOOK:site.yml.sample} --extra-vars "\ + no_log_on_ceph_key_tasks=false \ yes_i_know=true \ ireallymeanit=yes \ ceph_docker_registry_auth=True \