From fd0da6f43c8edb246d5c1ae4ebfc1bd17f05df53 Mon Sep 17 00:00:00 2001 From: Guillaume Abrioux Date: Tue, 13 Apr 2021 14:40:48 +0200 Subject: [PATCH] fs2bs: add a final play This removes the fact `skipped_nodes` which is useless when we run with `--limit` since it gets reset when a new iteration is made. Instead, let's print within a final play which node has been skipped reusing the `skip_this_node` fact. Signed-off-by: Guillaume Abrioux (cherry picked from commit 3d4267051f03c053dcd7d3f6f381988be0b2939d) --- .../filestore-to-bluestore.yml | 23 +++++++++---------- 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/infrastructure-playbooks/filestore-to-bluestore.yml b/infrastructure-playbooks/filestore-to-bluestore.yml index e28a7c27a..87b32282b 100644 --- a/infrastructure-playbooks/filestore-to-bluestore.yml +++ b/infrastructure-playbooks/filestore-to-bluestore.yml @@ -67,12 +67,6 @@ set_fact: skip_this_node: "{{ ('filestore' in _osd_objectstore and 'bluestore' in _osd_objectstore and not force_filestore_to_bluestore | default(False)) or ('filestore' not in _osd_objectstore) }}" - - name: add node to skipped node list - set_fact: - skipped_nodes: "{{ skipped_nodes | default([]) | union([inventory_hostname]) }}" - when: - - skip_this_node | bool - - name: filestore to bluestore migration workflow when: not skip_this_node | bool block: @@ -432,14 +426,19 @@ - import_role: name: ceph-osd +- name: final play + hosts: "{{ osd_group_name }}" + become: true + gather_facts: false + tasks: + + - import_role: + name: ceph-defaults - name: report any skipped node during this playbook debug: msg: | "WARNING:" - "The following nodes were skipped because OSDs are either" - "all bluestore ones or there's a mix of filestore and bluestore OSDs" - - "{{ ' '.join(skipped_nodes) }}" + "This node has been skipped because OSDs are either" + "all bluestore or there's a mix of filestore and bluestore OSDs" when: - - inventory_hostname == ansible_play_hosts_all | last - - skipped_nodes is defined + - skip_this_node | bool \ No newline at end of file