ceph
/
ceph-ansible
mirror of https://github.com/ceph/ceph-ansible.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
6,117 Commits
79 Branches
457 Tags
50 MiB
Commit Graph

12 Commits (main)

Author SHA1 Message Date
Guillaume Abrioux 18da10bb7a address Ansible linter errors 
This addresses all errors reported by the Ansible linter.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
 2024-02-16 00:38:19 +01:00
Alex Schultz a7f2fa73e6 Use ansible_facts 
It has come to our attention that using ansible_* vars that are
populated with INJECT_FACTS_AS_VARS=True is not very performant.  In
order to be able to support setting that to off, we need to update the
references to use ansible_facts[<thing>] instead of ansible_<thing>.

Related: ansible#73654
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1935406
Signed-off-by: Alex Schultz <aschultz@redhat.com>
 2021-03-08 20:54:02 +01:00
Rishabh Dave 739a662c80 improve coding style 
Keywords requiring only one item shouldn't express it by creating a
list with single item.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
 2019-04-23 15:37:07 +02:00
Rishabh Dave e0beaf123a "when" keyword should precede "block" keyword 
Otherwise the reader is forced to search for "when" when blocks are too
long.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
 2019-03-29 16:16:04 +00:00
Rishabh Dave 8edbda96df use blocks directives to group tasks 
Using block directives simplifies the playbooks and makes them more
readable.

Fixes: https://github.com/ceph/ceph-ansible/issues/2835
Signed-off-by: Rishabh Dave <ridave@redhat.com>
 2018-10-31 09:37:43 +01:00
Markos Chandras 849786967a ceph-common: Add initial support for openSUSE Leap distributions 
openSUSE Leap 42.3 provides support for Ceph Luminous in both the
distribution package and the latest available version in the OBS
repository so add these as the only available installation methods for
openSUSE.

Signed-off-by: Markos Chandras <mchandras@suse.de>
 2017-11-14 10:51:22 +00:00
Major Hayden f73232caa4
Use check_mode instead of always_run 
This patch changes the `always_run: yes` task option to
`check_mode: no` to avoid Ansible warnings.
 2017-10-25 09:53:34 -05:00
Major Hayden c2b5118c1b
Revert "Avoid deprecated always_run" 
This reverts commit 620fb37dd4.
 2017-10-25 09:48:09 -05:00
Andy McCrae 9ebef8ba3c Add regexp check for setting CLUSTER_NAME 
Minor fix to ensure that existing CLUSTER_NAME is changed, and avoid duplicates.
 2017-10-23 14:42:07 +01:00
Major Hayden 620fb37dd4
Avoid deprecated always_run 
The `always_run` key is deprecated and being removed in Ansible 2.4.
Using it causes a warning to be displayed:

    [DEPRECATION WARNING]: always_run is deprecated.

This patch changes all instances of `always_run` to use the `always`
tag, which causes the task to run each time the playbook runs.
 2017-10-12 08:29:44 -05:00
Sébastien Han d100b4e596 name includes and set_fact for clarity 
When Ansible is not run with verbose options it's difficult to see which
include and/or set_fact does what. So adding a name for each clarifies.

Signed-off-by: Sébastien Han <seb@redhat.com>
 2017-09-18 23:39:46 +02:00
Sébastien Han 189f4fee47 common: do not run tasks in main.yml, use include 
For readibility and clarity we do not run any tasks directly in the
main.yml file. This file should only contain include, which helps us
later to apply conditionnals if we want to.

Signed-off-by: Sébastien Han <seb@redhat.com>
 2016-12-09 16:00:46 +01:00