ceph-ansible

Commit Graph

Author	SHA1	Message	Date
Guillaume Abrioux	05c4d17d9a	address Ansible linter errors This addresses all errors reported by the Ansible linter. Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>	2024-03-07 21:03:32 +01:00
Benoît Knecht	bffca06837	ceph-handler: Fix check mode When running in check mode with one or more Ceph daemons that need to be restarted, the `tmpdirpath.path` variable that several handlers rely on is undefined, leading to fatal errors. This commit ensures the tasks that require `tmpdirpath.path` are skipped when it's undefined. Signed-off-by: Benoît Knecht <bknecht@protonmail.ch>	2022-01-06 10:46:55 +01:00
Matthew Vernon	7963a76c7a	Use a tempfile directory to store restart scripts Make a tempfile directory and copy the restart scripts there (and then execute them from there), rather than using insecure known filenames in /tmp/ This is a partial fix for ceph/ceph-ansible#2937 Signed-off-by: Matthew Vernon <mv3@sanger.ac.uk>	2020-04-06 22:55:51 +02:00
Guillaume Abrioux	30200802d9	handler: fix bug `411bd07d54` introduced a bug in handlers using `handler__status` instead of `hostvars[item]['handler__status']` causes handlers to be triggered in anycase even though `handler_*_status` was set to `False` on a specific node. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1622688 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>	2020-01-08 17:11:42 -05:00
Dimitri Savineau	fe9c5b8c68	ceph-handler: group listen topics and condition We are using multiple listen topics with the handlers. That means that we are notifying 4 tasks for each handler. Instead we can group the listen on an include_tasks and based on the group condition. Before: NOTIFIED HANDLER ceph-handler : set _mon_handler_called before restart for mon0 NOTIFIED HANDLER ceph-handler : copy mon restart script for mon0 NOTIFIED HANDLER ceph-handler : restart ceph mon daemon(s) for mon0 NOTIFIED HANDLER ceph-handler : set _mon_handler_called after restart for mon0 NOTIFIED HANDLER ceph-handler : set _osd_handler_called before restart for mon0 NOTIFIED HANDLER ceph-handler : copy osd restart script for mon0 NOTIFIED HANDLER ceph-handler : restart ceph osds daemon(s) for mon0 NOTIFIED HANDLER ceph-handler : set _osd_handler_called after restart for mon0 NOTIFIED HANDLER ceph-handler : set _mds_handler_called before restart for mon0 NOTIFIED HANDLER ceph-handler : copy mds restart script for mon0 NOTIFIED HANDLER ceph-handler : restart ceph mds daemon(s) for mon0 NOTIFIED HANDLER ceph-handler : set _mds_handler_called after restart for mon0 NOTIFIED HANDLER ceph-handler : set _rgw_handler_called before restart for mon0 NOTIFIED HANDLER ceph-handler : copy rgw restart script for mon0 NOTIFIED HANDLER ceph-handler : restart ceph rgw daemon(s) for mon0 NOTIFIED HANDLER ceph-handler : set _rgw_handler_called after restart for mon0 NOTIFIED HANDLER ceph-handler : set _mgr_handler_called before restart for mon0 NOTIFIED HANDLER ceph-handler : copy mgr restart script for mon0 NOTIFIED HANDLER ceph-handler : restart ceph mgr daemon(s) for mon0 NOTIFIED HANDLER ceph-handler : set _mgr_handler_called after restart for mon0 NOTIFIED HANDLER ceph-handler : set _rbdmirror_handler_called before restart for mon0 NOTIFIED HANDLER ceph-handler : copy rbd mirror restart script for mon0 NOTIFIED HANDLER ceph-handler : restart ceph rbd mirror daemon(s) for mon0 NOTIFIED HANDLER ceph-handler : set _rbdmirror_handler_called after restart for mon0 After: NOTIFIED HANDLER ceph-handler : mons handler for mon0 NOTIFIED HANDLER ceph-handler : osds handler for mon0 NOTIFIED HANDLER ceph-handler : mdss handler for mon0 NOTIFIED HANDLER ceph-handler : rgws handler for mon0 NOTIFIED HANDLER ceph-handler : mgrs handler for mon0 NOTIFIED HANDLER ceph-handler : rbdmirrors handler for mon0 Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>	2019-10-11 15:43:58 -04:00

5 Commits (438da91b324a001ed0c5e52e4235ad0f3a9817e2)