ceph
/
ceph-ansible
mirror of https://github.com/ceph/ceph-ansible.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
4,213 Commits
79 Branches
457 Tags
50 MiB
Commit Graph

13 Commits (56215d76885989b731e5dfceec01141109689824)

Author SHA1 Message Date
Rishabh Dave 380168dadc don't use "include" to include tasks 
Use "import_tasks" or "include_tasks" instead.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
 2018-09-27 17:53:40 +02:00
Guillaume Abrioux deaf273b25 syntax: change local_action syntax 
Use a nicer syntax for `local_action` tasks.
We used to have oneliner like this:
```
local_action: wait_for port=22 host={{ hostvars[inventory_hostname]['ansible_default_ipv4']['address'] }} state=started delay=10 timeout=500 }}
```

The usual syntax:
```
    local_action:
      module: wait_for
      port: 22
      host: "{{ hostvars[inventory_hostname]['ansible_default_ipv4']['address'] }}"
      state: started
      delay: 10
      timeout: 500
```
is nicer and kind of way to keep consistency regarding the whole
playbook.

This also fix a potential issue about missing quotation :

```
Traceback (most recent call last):
  File "/tmp/ansible_wQtWsi/ansible_module_command.py", line 213, in <module>
    main()
  File "/tmp/ansible_wQtWsi/ansible_module_command.py", line 185, in main
    rc, out, err = module.run_command(args, executable=executable, use_unsafe_shell=shell, encoding=None, data=stdin)
  File "/tmp/ansible_wQtWsi/ansible_modlib.zip/ansible/module_utils/basic.py", line 2710, in run_command
  File "/usr/lib64/python2.7/shlex.py", line 279, in split
    return list(lex)                                                                                                                                                                                                                                                                                                            File "/usr/lib64/python2.7/shlex.py", line 269, in next
    token = self.get_token()
  File "/usr/lib64/python2.7/shlex.py", line 96, in get_token
    raw = self.read_token()
  File "/usr/lib64/python2.7/shlex.py", line 172, in read_token
    raise ValueError, "No closing quotation"
ValueError: No closing quotation
```

writing `local_action: shell echo {{ fsid }} | tee {{ fetch_directory }}/ceph_cluster_uuid.conf`
can cause trouble because it's complaining with missing quotes, this fix solves this issue.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1510555

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
 2018-01-31 10:45:34 +01:00
Major Hayden f73232caa4
Use check_mode instead of always_run 
This patch changes the `always_run: yes` task option to
`check_mode: no` to avoid Ansible warnings.
 2017-10-25 09:53:34 -05:00
Major Hayden c2b5118c1b
Revert "Avoid deprecated always_run" 
This reverts commit 620fb37dd4.
 2017-10-25 09:48:09 -05:00
Major Hayden 620fb37dd4
Avoid deprecated always_run 
The `always_run` key is deprecated and being removed in Ansible 2.4.
Using it causes a warning to be displayed:

    [DEPRECATION WARNING]: always_run is deprecated.

This patch changes all instances of `always_run` to use the `always`
tag, which causes the task to run each time the playbook runs.
 2017-10-12 08:29:44 -05:00
Davide Belloni 87373e75d9 Adding Proxy support 2016-12-15 15:28:59 +01:00
Daniel Marks 2e50e5ba88 Better --check compatibility for ceph-common-coreos role 
Carefully chosen "always_run: true" parameters for read-only tasks that
register variables. This enables --check runs (at least on deployed
clusters).
 2016-11-26 17:48:06 +01:00
James Saint-Rossy d4a60a9394 Added ceph_release generation and fixed missing whitespace in ceph_release checks 2016-09-09 18:16:41 -04:00
pprokop e31efd7ebf Fix not creating pypy_binary_direcotry 2016-06-28 12:11:42 +02:00
Sébastien Han b0f56590e0 docker: fix tons of issues 
Signed-off-by: Sébastien Han <seb@redhat.com>
 2016-03-24 17:55:21 +01:00
pprokop b9b04a4cff Removing extra spaces in get_pip 2016-03-24 16:24:44 +01:00
pprokop 3e935a2776 Removing extra spaces 2016-03-24 16:24:44 +01:00
pprokop 6b014d10ed Adding role for deploying python on CoreOS 2016-03-24 16:24:44 +01:00