Rishabh Dave
739a662c80
improve coding style
...
Keywords requiring only one item shouldn't express it by creating a
list with single item.
Signed-off-by: Rishabh Dave <ridave@redhat.com>
2019-04-23 15:37:07 +02:00
Rishabh Dave
e0beaf123a
"when" keyword should precede "block" keyword
...
Otherwise the reader is forced to search for "when" when blocks are too
long.
Signed-off-by: Rishabh Dave <ridave@redhat.com>
2019-03-29 16:16:04 +00:00
Guillaume Abrioux
d7e77012ef
retry on packages and repositories failures
...
add register/until on all packaging related tasks to avoid non valid CI
failure.
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2018-12-19 14:48:27 +00:00
Rishabh Dave
d72340abbe
pass the list of packages to package management modules
...
Instead of looping over a list of packages or repeating the task
separately for different packages, pass the list of packages to the
task performing package management.
Signed-off-by: Rishabh Dave <ridave@redhat.com>
2018-11-09 12:59:08 +00:00
Rishabh Dave
8edbda96df
use blocks directives to group tasks
...
Using block directives simplifies the playbooks and makes them more
readable.
Fixes: https://github.com/ceph/ceph-ansible/issues/2835
Signed-off-by: Rishabh Dave <ridave@redhat.com>
2018-10-31 09:37:43 +01:00