ceph-ansible

Commit Graph

Author	SHA1	Message	Date
Benoît Knecht	7684d892c0	ceph-facts: Fix get_def_crush_rule_name.yml in check mode This construct doesn't work as intended since ansible/ansible#74212: ``` item.stdout \| default('{}') \| from_json ``` That PR made the `command` module return `stdout` even in check mode (setting it to the empty string), so `default()` has no effect in that case and `from_json()` fails to parse an empty string. Instead, `default()` needs to be invoked with its second argument set to `True`, so that it replaces any `False` value (such as an empty string) with its first argument: ``` item.stdout \| default('{}', True) \| from_json ``` Signed-off-by: Benoît Knecht <bknecht@protonmail.ch>	2022-02-07 14:13:19 +01:00
Dimitri Savineau	2e417ab901	library: add ceph_crush_rule module This adds ceph_crush_rule ansible module for replacing the command module usage with the ceph osd crush rule commands. This module can manage both erasure and replicated crush rules. Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>	2020-12-01 17:52:41 +01:00
Guillaume Abrioux	1bb9860dfd	osd: use default crush rule name when needed When `rule_name` isn't set in `crush_rules` the osd pool creation will fail. This commit adds a new fact `ceph_osd_pool_default_crush_rule_name` with the default crush rule name. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1817586 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>	2020-03-31 14:49:38 -04:00

Author

SHA1

Message

Date

Benoît Knecht

7684d892c0

ceph-facts: Fix get_def_crush_rule_name.yml in check mode

This construct doesn't work as intended since ansible/ansible#74212:

```
item.stdout | default('{}') | from_json
```

That PR made the `command` module return `stdout` even in check mode (setting
it to the empty string), so `default()` has no effect in that case and
`from_json()` fails to parse an empty string.

Instead, `default()` needs to be invoked with its second argument set to
`True`, so that it replaces any `False` value (such as an empty string) with
its first argument:

```
item.stdout | default('{}', True) | from_json
```

Signed-off-by: Benoît Knecht <bknecht@protonmail.ch>

2022-02-07 14:13:19 +01:00

Dimitri Savineau

2e417ab901

library: add ceph_crush_rule module

This adds ceph_crush_rule ansible module for replacing the command
module usage with the ceph osd crush rule commands.
This module can manage both erasure and replicated crush rules.

Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>

2020-12-01 17:52:41 +01:00

Guillaume Abrioux

1bb9860dfd

osd: use default crush rule name when needed

When `rule_name` isn't set in `crush_rules` the osd pool creation will
fail.
This commit adds a new fact `ceph_osd_pool_default_crush_rule_name` with
the default crush rule name.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1817586

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

2020-03-31 14:49:38 -04:00

3 Commits (af0624150d22bd10581acb492b6e7bc3cd283a17)