--- # NOTE (leseb): current behavior of ceph-disk is to fail when the device is mounted "stderr: ceph-disk: Error: Device is mounted: /dev/sdb1" # the return code is 1, which makes sense, however ideally if ceph-disk will detect a ceph partition # it should exist we rc=0 and don't do anything unless we do something like --force # As as a final word, I prefer to keep the partition check instead of running ceph-disk prepare with "failed_when: false" # I believe it's safer # # regex syntax uses (pat1|pat2|...|patN) for different families of device # names, but has a common expression for partition number at the end. # allow 2-digit partition numbers so fast SSDs can be shared by > 9 disks # for SSD journals. - include: ./check_devices_static.yml when: - not osd_auto_discovery # Hard code this so we will skip the entire file instead of individual tasks (Default isn't Consistent) static: False - include: ./check_devices_auto.yml when: - osd_auto_discovery # Hard code this so we will skip the entire file instead of individual tasks (Default isn't Consistent) static: False - name: check the journal device is partition shell: "readlink -f {{ item }} | egrep '/dev/([hsv]d[a-z]{1,2}|cciss/c[0-9]d[0-9]p|nvme[0-9]n[0-9]p)[0-9]{1,2}|fio[a-z]{1,2}[0-9]{1,2}$'" with_items: "{{ dedicated_devices }}" changed_when: false failed_when: false always_run: true register: journal_ispartition_results - name: check the partition status of the journal devices shell: "parted --script {{ item.1 }} print > /dev/null 2>&1" with_together: - "{{ journal_ispartition_results.results }}" - "{{ dedicated_devices|unique }}" changed_when: false failed_when: false always_run: true register: journal_partition_status when: - osd_scenario == 'non-collocated' - item.0.rc != 0 - name: fix partitions gpt header or labels of the journal devices shell: "sgdisk --zap-all --clear --mbrtogpt -- {{ item.1 }} || sgdisk --zap-all --clear --mbrtogpt -- {{ item.1 }}" with_together: - "{{ journal_partition_status.results }}" - "{{ dedicated_devices|unique }}" changed_when: false when: - osd_scenario == 'non-collocated' - not item.0.get("skipped") - item.0.get("rc", 0) != 0