mirror of https://github.com/ceph/ceph-ansible.git
45d46541cb
There's two big issues with the current OSD restart script. 1/ We try to test if the ceph osd daemon socket exists but we use a wildcard for the socket name : /var/run/ceph/*.asok. This fails because we usually have multiple ceph osd sockets (or other ceph daemon collocated) present in /var/run/ceph directory. Currently the test fails with: bash: line xxx: [: too many arguments But it doesn't stop the script execution. Instead we can specify the full ceph osd socket name because we already know the OSD id. 2/ The container filter pattern is wrong and could matches multiple containers resulting the script to fail. We use the filter with two different patterns. One is with the device name (sda, sdb, ..) and the other one is with the OSD id (ceph-osd-0, ceph-osd-15, ..). In both case we could match more than needed. $ docker container ls CONTAINER ID IMAGE NAMES 958121a7cc7d ceph-daemon:latest ceph-osd-strg0-sda 589a982d43b5 ceph-daemon:latest ceph-osd-strg0-sdb 46c7240d71f3 ceph-daemon:latest ceph-osd-strg0-sdaa 877985ec3aca ceph-daemon:latest ceph-osd-strg0-sdab $ docker container ls -q -f "name=sda" 958121a7cc7d 46c7240d71f3 877985ec3aca $ docker container ls CONTAINER ID IMAGE NAMES 2db399b3ee85 ceph-daemon:latest ceph-osd-5 099dc13f08f1 ceph-daemon:latest ceph-osd-13 5d0c2fe8f121 ceph-daemon:latest ceph-osd-17 d6c7b89db1d1 ceph-daemon:latest ceph-osd-1 $ docker container ls -q -f "name=ceph-osd-1" 099dc13f08f1 5d0c2fe8f121 d6c7b89db1d1 Adding an extra '$' character at the end of the pattern solves the problem. Finally removing the get_container_osd_id function because it's not used in the script at all. Signed-off-by: Dimitri Savineau <dsavinea@redhat.com> |
||
|---|---|---|
| .. | ||
| ceph-client | ||
| ceph-common | ||
| ceph-config | ||
| ceph-container-common | ||
| ceph-container-engine | ||
| ceph-dashboard | ||
| ceph-defaults | ||
| ceph-facts | ||
| ceph-fetch-keys | ||
| ceph-grafana | ||
| ceph-handler | ||
| ceph-infra | ||
| ceph-iscsi-gw | ||
| ceph-mds | ||
| ceph-mgr | ||
| ceph-mon | ||
| ceph-nfs | ||
| ceph-node-exporter | ||
| ceph-osd | ||
| ceph-prometheus | ||
| ceph-rbd-mirror | ||
| ceph-rgw | ||
| ceph-rgw-loadbalancer | ||
| ceph-validate | ||