From 22bb0976d5a4ea844f5a2e37e855a57ea705bd43 Mon Sep 17 00:00:00 2001
From: Max Gautier <mg@max.gautier.name>
Date: Mon, 22 Jan 2024 17:49:14 +0100
Subject: [PATCH] Adjust kubelet_event_record_qps to K8S default (#10826)

Also remove redundant check in the kubelet config template (we define a
default, so the setting will always be "true")
---
 .../kubernetes/node/templates/kubelet-config.v1beta1.yaml.j2  | 2 --
 roles/kubespray-defaults/defaults/main/main.yml               | 4 ++--
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/roles/kubernetes/node/templates/kubelet-config.v1beta1.yaml.j2 b/roles/kubernetes/node/templates/kubelet-config.v1beta1.yaml.j2
index f54d1f8b3..1cd00992a 100644
--- a/roles/kubernetes/node/templates/kubelet-config.v1beta1.yaml.j2
+++ b/roles/kubernetes/node/templates/kubelet-config.v1beta1.yaml.j2
@@ -135,9 +135,7 @@ tlsCipherSuites:
 - {{ tls }}
 {% endfor %}
 {% endif %}
-{% if kubelet_event_record_qps %}
 eventRecordQPS: {{ kubelet_event_record_qps }}
-{% endif %}
 shutdownGracePeriod: {{ kubelet_shutdown_grace_period }}
 shutdownGracePeriodCriticalPods: {{ kubelet_shutdown_grace_period_critical_pods }}
 {% if not kubelet_fail_swap_on %}
diff --git a/roles/kubespray-defaults/defaults/main/main.yml b/roles/kubespray-defaults/defaults/main/main.yml
index cbad203e4..f0290061d 100644
--- a/roles/kubespray-defaults/defaults/main/main.yml
+++ b/roles/kubespray-defaults/defaults/main/main.yml
@@ -645,9 +645,9 @@ host_os: >-
   {{ ansible_system }}
   {%- endif -%}
 
-# Sets the eventRecordQPS parameter in kubelet-config.yaml. The default value is 5 (see types.go)
+# Sets the eventRecordQPS parameter in kubelet-config.yaml.
 # Setting it to 0 allows unlimited requests per second.
-kubelet_event_record_qps: 5
+kubelet_event_record_qps: 50
 
 proxy_env_defaults:
   http_proxy: "{{ http_proxy | default('') }}"