From a7ace2e55b490194e36645c614e6d86bb963bbc8 Mon Sep 17 00:00:00 2001 From: Max Gautier Date: Mon, 7 Oct 2024 13:58:04 +0200 Subject: [PATCH] ansible-lint: Adjust pre-commit hooks dependencies Dropping the ansible dependencies for ansible-lint will allow us to catch missing dependencies collections in galaxy.yml. For collections needed for contrib/ or tests/ (i.e: not part of core kubespray dependencies), we can just configure ansible-lint to mock them. This mean it won't check the mocked module parameters, but for those area of the code base it's an acceptable trade-off. --- .ansible-lint | 2 ++ .pre-commit-config.yaml | 1 - tests/requirements.yml | 3 --- 3 files changed, 2 insertions(+), 4 deletions(-) delete mode 100644 tests/requirements.yml diff --git a/.ansible-lint b/.ansible-lint index 75ae44c14..68a403363 100644 --- a/.ansible-lint +++ b/.ansible-lint @@ -37,3 +37,5 @@ exclude_paths: - tests/files/custom_cni/cilium.yaml - venv - .github +mock_modules: + - gluster.gluster.gluster_volume diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 3592fb258..834040d2e 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -39,7 +39,6 @@ repos: hooks: - id: ansible-lint additional_dependencies: - - ansible==9.8.0 - jsonschema==4.22.0 - jmespath==1.0.1 - netaddr==1.3.0 diff --git a/tests/requirements.yml b/tests/requirements.yml deleted file mode 100644 index 6eeb070ec..000000000 --- a/tests/requirements.yml +++ /dev/null @@ -1,3 +0,0 @@ ---- -collections: - - name: gluster.gluster