2021-02-18 03:28:51 +08:00
|
|
|
//===-- Passes.td - Pass definition file -------------------*- tablegen -*-===//
|
|
|
|
//
|
|
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
#ifndef NPCOMP_TORCH_PASSES
|
|
|
|
#define NPCOMP_TORCH_PASSES
|
|
|
|
|
|
|
|
include "mlir/Pass/PassBase.td"
|
|
|
|
|
|
|
|
def GlobalizeObjectGraph : Pass<"torch-globalize-object-graph", "ModuleOp"> {
|
|
|
|
let summary = "Converts TorchScript object graphs to a globalized form";
|
|
|
|
let constructor = "mlir::NPCOMP::Torch::createGlobalizeObjectGraphPass()";
|
|
|
|
let description = [{
|
|
|
|
This pass converts a subset of possible TorchScript modules into a
|
|
|
|
more restrictive lower-level form that strips away the need to be
|
|
|
|
concerned with instances of !torch.nn.Module<...> type. Specifically,
|
|
|
|
the object graph is flattened into a set of discrete globals
|
|
|
|
(`torch.global_slot`) that hold the program state.
|
|
|
|
|
|
|
|
The overarching goal is for a strict correspondence between the original
|
|
|
|
`torch.nn.Module` (call it `root`) that the user `torch.jit.script`'ed, and
|
|
|
|
the public interface of the resulting MLIR module. Specifically:
|
|
|
|
- The call `root.encoder.forward(...)` in Python corresponds to invoking
|
|
|
|
the `func @encoder.forward` on the resulting MLIR module.
|
|
|
|
- The data member access `root.decoder.ids_to_strings_table` in Python
|
|
|
|
corresponds to accessing the
|
|
|
|
`torch.global_slot @decoder.ids_to_strings_table` on the resulting
|
|
|
|
MLIR module.
|
|
|
|
In effect, the entire MLIR module corresponds to an instance of the `root`
|
|
|
|
object. This matches with the intuitive behavior desired for deployment:
|
|
|
|
When the MLIR module (or, more likely, a compiled artifact derived from it)
|
|
|
|
is loaded in a deployed environment, it is equivalent to recreating the
|
|
|
|
original `root` object.
|
|
|
|
|
|
|
|
This pass performs a complete change of the externally visible calling
|
|
|
|
convention of the MLIR module for a graph of objects and methods to a
|
Support multiple instances of a class in GlobalizeObjectGraph.
This happens in practice with e.g. ResNet from torchvision (multiple
instances of the same BatchNorm class).
The key observation is that for this program, and the expected set of
programs, we can convert the program to the same globalized form with a
bit more static analysis and effort to suitably monomorphize the
program. Though what we are doing here is fairly annoying to implement,
it saves any nontrivial later pass from having to do similar analyses
(or worse). E.g. shape inference would need to be object-graph aware,
mutation/lifetime analyses would have to be aware, etc. Additionally, it
would make us front-load what it means to have a !torch.nn.Module type
on an ABI boundary, which we are just not ready to handle.
I'm really, really hoping that in practice we can get away with
this, otherwise it's going to be really rough designing a representation
(and implementing everything to back it) that is convenient to transform
and gracefully scales from full object graph (in the most dynamic case)
down to a fixed set of global slots like we have here (in the most
static case, which we presume a lot of practical programs fall into).
This also involved introducing a
`torch-prepare-for-globalize-object-graph` pass that does a minimal set of
lowerings to simplify the IR into a more orthogonal and analyzable form,
and a `torch-globalize-pipeline` helper.
Recommended review order:
- updated documentation in Passes.td
- new tests in `globalize-object-graph-multiple-instances*.mlir`
- implementation of GlobalizeObjectGraph.cpp
- PrepareForGlobalizeObjectGraph.cpp + prepare-for-globalize-object-graph.mlir
- misc stuff like torch-globalize-pipeline pipeline definition.
With this, we can import, globalize, and inline resnet18 from
torchvision:
https://gist.github.com/silvasean/821586afc19b67d9fb72030b2e0adeb8
2021-03-10 12:33:21 +08:00
|
|
|
fixed set of globals and functions. Additionally, method signatures are
|
|
|
|
changed such that all types of !torch.nn.Module are deleted from public
|
|
|
|
interfaces since they are guaranteed to correspond to a unique instance and
|
|
|
|
are thus redundant.
|
2021-02-18 03:28:51 +08:00
|
|
|
|
|
|
|
Of course, only a subset of programs can be transformed, and this pass fails
|
|
|
|
with an error if the conditions are violated.
|
|
|
|
|
|
|
|
Specifically, the restrictions are:
|
|
|
|
- There must be a unique torch.nn_module that is not the value of a slot
|
|
|
|
of any other torch.nn_module
|
|
|
|
- Rationale: Allows us to have a notion of a unique "root" op, which is
|
|
|
|
used to define linkage. This also matches how TorchScript imports in
|
|
|
|
practice (`torch.jit.script` imports a single root object).
|
Support multiple instances of a class in GlobalizeObjectGraph.
This happens in practice with e.g. ResNet from torchvision (multiple
instances of the same BatchNorm class).
The key observation is that for this program, and the expected set of
programs, we can convert the program to the same globalized form with a
bit more static analysis and effort to suitably monomorphize the
program. Though what we are doing here is fairly annoying to implement,
it saves any nontrivial later pass from having to do similar analyses
(or worse). E.g. shape inference would need to be object-graph aware,
mutation/lifetime analyses would have to be aware, etc. Additionally, it
would make us front-load what it means to have a !torch.nn.Module type
on an ABI boundary, which we are just not ready to handle.
I'm really, really hoping that in practice we can get away with
this, otherwise it's going to be really rough designing a representation
(and implementing everything to back it) that is convenient to transform
and gracefully scales from full object graph (in the most dynamic case)
down to a fixed set of global slots like we have here (in the most
static case, which we presume a lot of practical programs fall into).
This also involved introducing a
`torch-prepare-for-globalize-object-graph` pass that does a minimal set of
lowerings to simplify the IR into a more orthogonal and analyzable form,
and a `torch-globalize-pipeline` helper.
Recommended review order:
- updated documentation in Passes.td
- new tests in `globalize-object-graph-multiple-instances*.mlir`
- implementation of GlobalizeObjectGraph.cpp
- PrepareForGlobalizeObjectGraph.cpp + prepare-for-globalize-object-graph.mlir
- misc stuff like torch-globalize-pipeline pipeline definition.
With this, we can import, globalize, and inline resnet18 from
torchvision:
https://gist.github.com/silvasean/821586afc19b67d9fb72030b2e0adeb8
2021-03-10 12:33:21 +08:00
|
|
|
- Multiple instances of the same class type are allowed, as long as it is
|
|
|
|
possible to monomorphize ("template instantiate") functions so that each
|
|
|
|
argument of !torch.nn.Module type corresponds to a unique instance.
|
|
|
|
In pratice, this limitation is either 1) (fundamental) due to truly
|
|
|
|
dynamic use of modules, such as `m1 if cond() else m2` in Python code,
|
|
|
|
or 2) (incidental) imprecision of the static analysis used in this pass
|
|
|
|
which is used to calculate when a single intance is relevant. In general,
|
|
|
|
this analysis is equivalent to the halting problem, but we can aim to
|
|
|
|
improve this pass such that practical patterns are all handled.
|
|
|
|
- Rationale: The fundamental limitation "1)" guarantees that the
|
|
|
|
program can be lowered to a fixed set of globals without indirection
|
|
|
|
across globals. In the absence of this property, most compiler
|
|
|
|
analyses/transformations are significantly curtailed (or require very
|
|
|
|
sophisticated implementations). For the moment, this restriction
|
|
|
|
is deemed to be sufficiently reasonable to be a pragmatic choice to
|
|
|
|
avoid front-loading the complexity of working with a representation that
|
|
|
|
really does a good job of representing that kind of program.
|
|
|
|
Additionally, it avoids front-loading the handling of programs which
|
|
|
|
have !torch.nn.Module types at external calling convention boundaries.
|
2021-02-18 03:28:51 +08:00
|
|
|
- All torch.nn_module's must be reachable by a unique path from the root
|
|
|
|
- Rationale: Eliminates possibility of potentially exponential number of
|
|
|
|
paths. Or worse, infinite number of paths when considering cyclic
|
|
|
|
object graphs. Also as of Feb 2021, TorchScript won't import into
|
|
|
|
this form (it has a bug related to the identity of submodules).
|
2021-02-26 07:54:51 +08:00
|
|
|
- Two slots cannot have initial values that alias each other.
|
|
|
|
- Rationale: This makes the representation of initial values simpler. Also
|
|
|
|
as of Feb 2021, TorchScript won't import into this form except
|
|
|
|
potentially for Tensors (it has a bug related to the identity of
|
|
|
|
objects). And for tensors, the npcomp IValue importer only supports a
|
|
|
|
very restricted form of aliasing anyway for other reasons. We are
|
|
|
|
waiting for signals that more general handling of object aliasing is
|
|
|
|
important to devote the effort to it.
|
2021-02-18 03:28:51 +08:00
|
|
|
}];
|
|
|
|
}
|
|
|
|
|
Support multiple instances of a class in GlobalizeObjectGraph.
This happens in practice with e.g. ResNet from torchvision (multiple
instances of the same BatchNorm class).
The key observation is that for this program, and the expected set of
programs, we can convert the program to the same globalized form with a
bit more static analysis and effort to suitably monomorphize the
program. Though what we are doing here is fairly annoying to implement,
it saves any nontrivial later pass from having to do similar analyses
(or worse). E.g. shape inference would need to be object-graph aware,
mutation/lifetime analyses would have to be aware, etc. Additionally, it
would make us front-load what it means to have a !torch.nn.Module type
on an ABI boundary, which we are just not ready to handle.
I'm really, really hoping that in practice we can get away with
this, otherwise it's going to be really rough designing a representation
(and implementing everything to back it) that is convenient to transform
and gracefully scales from full object graph (in the most dynamic case)
down to a fixed set of global slots like we have here (in the most
static case, which we presume a lot of practical programs fall into).
This also involved introducing a
`torch-prepare-for-globalize-object-graph` pass that does a minimal set of
lowerings to simplify the IR into a more orthogonal and analyzable form,
and a `torch-globalize-pipeline` helper.
Recommended review order:
- updated documentation in Passes.td
- new tests in `globalize-object-graph-multiple-instances*.mlir`
- implementation of GlobalizeObjectGraph.cpp
- PrepareForGlobalizeObjectGraph.cpp + prepare-for-globalize-object-graph.mlir
- misc stuff like torch-globalize-pipeline pipeline definition.
With this, we can import, globalize, and inline resnet18 from
torchvision:
https://gist.github.com/silvasean/821586afc19b67d9fb72030b2e0adeb8
2021-03-10 12:33:21 +08:00
|
|
|
def PrepareForGlobalizeObjectGraph
|
|
|
|
: Pass<"torch-prepare-for-globalize-object-graph", "ModuleOp"> {
|
|
|
|
let summary = "Lowering in preparation for globalizing";
|
|
|
|
let constructor = "mlir::NPCOMP::Torch::createPrepareForGlobalizeObjectGraphPass()";
|
|
|
|
let description = [{
|
|
|
|
Establishes and the invariants needed by the
|
|
|
|
torch-globalize-object-graph transformation. Fails if that cannot be
|
|
|
|
accomplished.
|
|
|
|
|
|
|
|
Currently, this just involves ensuring a small set of patterns have been
|
|
|
|
applied.
|
|
|
|
}];
|
|
|
|
}
|
|
|
|
|
2021-04-02 08:36:18 +08:00
|
|
|
def AdjustCallingConventions
|
|
|
|
: Pass<"torch-adjust-calling-conventions", "ModuleOp"> {
|
|
|
|
let summary = "Adjust the calling conventions of functions";
|
|
|
|
let constructor = "mlir::NPCOMP::Torch::createAdjustCallingConventionsPass()";
|
|
|
|
let description = [{
|
|
|
|
Adjusts the calling conventions of functions in the module, with the aim of
|
|
|
|
preparing them for backends and further lowering passes. As this changes
|
|
|
|
the module calling convention, it should be considered a legalization
|
|
|
|
step towards reaching IR that is suitable for an appropriate backend.
|
|
|
|
All transformations are context-free and suitable for documenting
|
|
|
|
at the user level if needed to clarify the eventual calling convention
|
|
|
|
of compiled artifacts.
|
|
|
|
This is not an optimization.
|
|
|
|
|
|
|
|
The transformations performed are:
|
|
|
|
- `torch.type_bound` annotations are incorporated into the type of the
|
|
|
|
function arguments, which should be `!numpy.ndarray<...>`'s.
|
|
|
|
- Python-isms are rewritten to MLIR-isms
|
|
|
|
- NoneType return is rewritten to the absence of a return value.
|
|
|
|
- (Not implemented yet) Tuple return is rewritten to multiple return
|
|
|
|
values
|
|
|
|
}];
|
|
|
|
}
|
|
|
|
|
2021-02-18 03:28:51 +08:00
|
|
|
#endif // NPCOMP_TORCH_PASSES
|