llvm
/
torch-mlir
mirror of https://github.com/llvm/torch-mlir
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Emit a proper error. 

This assertion was reachable from user code (e.g. !torch.qint8 dtype),
which should never be possible for an assertion.

Instead, emit a diagnostic.
pull/323/head
Sean Silva 2021-09-24 04:25:26 +00:00
parent a99cbeeb7e
commit 12d0fe7c85
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
external/torch-mlir/lib/Dialect/Torch/IR/TorchTypes.cpp vendored
View File

@ -263,7 +263,10 @@ static Type convertDtypeToBuiltinElementType(MLIRContext *context, Type dtype) {
return IntegerType::get(context, integerType.getWidth(), return IntegerType::get(context, integerType.getWidth(),
IntegerType::Signless); IntegerType::Signless);
} }
assert(false && "Unsupported dtype to convert to builtin element type"); emitError(UnknownLoc::get(context))
<< "unimplemented: conversion of dtype " << dtype
<< " to builtin tensor element type";
return nullptr;
} }
TensorType ValueTensorType::toBuiltinTensor() const { TensorType ValueTensorType::toBuiltinTensor() const {
@ -271,8 +274,10 @@ TensorType ValueTensorType::toBuiltinTensor() const {
return nullptr; return nullptr;
if (!hasSizes()) if (!hasSizes())
return UnrankedTensorType::get(getDtype()); return UnrankedTensorType::get(getDtype());
return RankedTensorType::get( Type elementType = convertDtypeToBuiltinElementType(getContext(), getDtype());
getSizes(), convertDtypeToBuiltinElementType(getContext(), getDtype())); if (!elementType)
return nullptr;
return RankedTensorType::get(getSizes(), elementType);
} }
LogicalResult LogicalResult