From b8ad0189ac65d3eb17885f48e1913b8450c5e931 Mon Sep 17 00:00:00 2001 From: Sean Silva Date: Tue, 20 Apr 2021 12:01:02 -0700 Subject: [PATCH] Add comment about relative import. This file needs to adopt best practices for how to structure python "main"'s, but I don't know how to do that yet. --- frontends/pytorch/e2e_testing/torchscript/main.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/frontends/pytorch/e2e_testing/torchscript/main.py b/frontends/pytorch/e2e_testing/torchscript/main.py index 4b06cc774..214be1c76 100644 --- a/frontends/pytorch/e2e_testing/torchscript/main.py +++ b/frontends/pytorch/e2e_testing/torchscript/main.py @@ -13,6 +13,12 @@ from torch_mlir.torchscript.e2e_test.configs import ( ) # Import tests to register them in the global registry. +# TODO: Use a relative import. +# That requires invoking this file as a "package" though, which makes it +# not possible to just do `python main.py`. Instead, it requires something +# like `python -m tochscript.main` which is annoying because it can only +# be run from a specific directory. +# TODO: Find out best practices for python "main" files. import basic def main():