torch-mlir

Commit Graph

Author	SHA1	Message	Date
Sean Silva	1b769f7841	Extend GlobalizeObjectGraph to handle torch.prim.GetAttr returning NnModuleType This happens in practice. With this, we can globalize slots for the non-trivial classifier layer obtained from https://github.com/NVIDIA/NeMo/blob/main/tutorials/nlp/Joint_Intent_and_Slot_Classification.ipynb This also adds support for tuple return types, which were needed by that model.	2021-02-19 10:23:25 -08:00
Sean Silva	7f7bf39551	Add prim::Print and fix prim::CallMethod For now, we are treating strings as bytes.	2021-02-10 15:15:56 -08:00
Sean Silva	c4e4a11e3f	Add support for prim::GetAttr/SetAttr/CallMethod/If This required some invasive surgery to graph_importer.h/cpp, specifically moving most of it into node_importer.h/cpp and relayering it. The abstraction that it had didn't work well in the recursive setting that happens with prim::If. The key observation is that torch::jit::Graph doesn't really correspond directly to anything on the MLIR side. It's a weird combination of a context, builder, and function and just holds a `torch::jit::Block`. It is `torch::jit::Node` and `torch::jit::Block` which form the recursive structure analogous to MLIR's operation/region/block. So node_importer.h/cpp makes sense as a core building block. As part of doing this, I did venture a bit into the AcapController code, and realize now that there is functionality duplicated there with the ivalue importer. Will refactor that soon.	2021-02-04 17:01:47 -08:00

Author

SHA1

Message

Date

Sean Silva

1b769f7841

Extend GlobalizeObjectGraph to handle torch.prim.GetAttr returning NnModuleType

This happens in practice. With this, we can globalize slots for the
non-trivial classifier layer obtained from
https://github.com/NVIDIA/NeMo/blob/main/tutorials/nlp/Joint_Intent_and_Slot_Classification.ipynb

This also adds support for tuple return types, which were needed by that
model.

2021-02-19 10:23:25 -08:00

Sean Silva

7f7bf39551

Add prim::Print and fix prim::CallMethod

For now, we are treating strings as bytes.

2021-02-10 15:15:56 -08:00

Sean Silva

c4e4a11e3f

Add support for prim::GetAttr/SetAttr/CallMethod/If

This required some invasive surgery to graph_importer.h/cpp,
specifically moving most of it into node_importer.h/cpp and relayering
it. The abstraction that it had didn't work well in the recursive
setting that happens with prim::If.

The key observation is that torch::jit::Graph doesn't really correspond
directly to anything on the MLIR side. It's a weird combination of a
context, builder, and function and just holds a `torch::jit::Block`. It
is `torch::jit::Node` and `torch::jit::Block` which form the recursive
structure analogous to MLIR's operation/region/block. So
node_importer.h/cpp makes sense as a core building block.

As part of doing this, I did venture a bit into the AcapController code,
and realize now that there is functionality duplicated there with the
ivalue importer. Will refactor that soon.

2021-02-04 17:01:47 -08:00

3 Commits (a375ccf9da42ae9c5449be52d660c904fc6d1c99)