llvm
/
torch-mlir
mirror of https://github.com/llvm/torch-mlir
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
torch-mlir/include/npcomp/Dialect/Torch/IR
History
Sean Silva 79928cd2dd Generalize support for elementwise ops. 
We plumb through e2e a fair number of interesting cases:
- unary, binary, ternary elementwise ops
- ops like `torch.aten.add.Tensor` that also take a scalar parameter
- static size-1 broadcasting

We allow the static size-1 broadcasting case, but emit a runtime error
in the case of dynamic size-1 broadcasting. This seems like a sweet spot
subset of things that can be lowered directly to linalg, while not being
overly constraining to users. This is consistent with what IREE is doing
for CHLO->Linalg lowering as well
([code](50bf7a87e4/iree/compiler/InputConversion/MHLO/BroadcastingToLinalgPatterns.cpp (L1))).

To test the static size-1 case, we added support for the
`torch.aten.unsqueeze` op and lowering for it through
`linalg.tensor_expand_shape`. This involved a generalization of
`MaximizeValueSemantics` able to handle it (the solution there also
works for `torch.aten.flatten.using_ints` which we need for ResNet
anyway)

Also, a few minor additional changes:
- Add `VerifyInvariantsBeforeBackendLowering` pass, which catches a
  large class of errors before we get to backend lowering (now that we
  are doing dialect conversion, the errors are way nicer if we just emit
  them up front rather than in the guts of a random pattern).
- Minor change to RefBackend to allow `linalg.tensor_expand_shape`.

Recommended review order:
- e2e tests in elementwise.py
- `ConvertElementwiseOp` in TorchToLinalg.cpp + elementwise.mlir test
- `ConvertAtenUnsqueezeOp` in TorchToLinalg.cpp + unsqueeze.mlir test
- RefineTypes.cpp + tests
- MaximizeValueSemantics changes + test
- VerifyInvariantsBeforeBackendLowering pass + test
 		2021-06-28 13:28:38 -07:00
..
.gitignore Significantly restructure torch/aten import design. 2021-05-19 13:37:39 -07:00
CMakeLists.txt Significantly restructure torch/aten import design. 2021-05-19 13:37:39 -07:00
GeneratedAtenOps.td Generalize support for elementwise ops. 2021-06-28 13:28:38 -07:00
GeneratedPrimOps.td Add CastOpInterface to torch.prim.unchecked_cast. 2021-06-23 08:07:45 -07:00
GeneratedQuantizedOps.td Add a !torch.float type. 2021-06-17 09:24:18 -07:00
TorchBase.td Add `!torch.bool` type. 2021-06-16 13:22:00 -07:00
TorchDialect.h Expose signature metadata to ops and implement ATenRecognizeKernelsPass pass. 2020-10-26 20:31:45 -07:00
TorchOps.h Add `!torch.int` type. 2021-06-17 07:28:23 -07:00
TorchOps.td Make MaximizeValueSemantics a bit smarter. 2021-06-22 16:48:57 -07:00
TorchTraits.h Significantly restructure torch/aten import design. 2021-05-19 13:37:39 -07:00
TorchTypes.h Move Torch type implementation code into TorchTypes.cpp 2021-06-10 16:46:47 -07:00
TorchTypes.td Add a !torch.float type. 2021-06-17 09:24:18 -07:00