ceph
/
ceph-ansible
mirror of https://github.com/ceph/ceph-ansible.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

validate: improve message printed in check_devices.yml 

The message prints the whole content of the registered variable in the
playbook, this is not needed and makes the message pretty unclear and
unreadable.

```
"msg": "{'_ansible_parsed': True, 'changed': False, '_ansible_no_log': False, u'err': u'Error: Could not stat device /dev/sdf - No such file or directory.\\n', 'item': u'/dev/sdf', '_ansible_item_result': True, u'failed': False, '_ansible_item_label': u'/dev/sdf', u'msg': u\"Error while getting device information with parted script: '/sbin/parted -s -m /dev/sdf -- unit 'MiB' print'\", u'rc': 1, u'invocation': {u'module_args': {u'part_start': u'0%', u'part_end': u'100%', u'name': None, u'align': u'optimal', u'number': None, u'label': u'msdos', u'state': u'info', u'part_type': u'primary', u'flags': None, u'device': u'/dev/sdf', u'unit': u'MiB'}}, 'failed_when_result': False, '_ansible_ignore_errors': None, u'out': u''} is not a block special file!"
```

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1719023

(cherry picked from commit e6dc3ebd8c)
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
pull/4222/head v3.2.20
Guillaume Abrioux 2019-07-10 15:08:39 +02:00 committed by Dimitri Savineau
parent d739f41549
commit 1716eea5e3
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
roles/ceph-validate/tasks/check_devices.yml
View File

@ -11,7 +11,7 @@
- name: fail if one of the devices is not a device - name: fail if one of the devices is not a device
fail: fail:
msg: "{{ item }} is not a block special file!" msg: "{{ item.item }} is not a block special file!"
when: item.rc is defined when: item.rc is defined
with_items: "{{ devices_parted.results }}" with_items: "{{ devices_parted.results }}"
when: when:
@ -29,7 +29,7 @@
- name: fail if one of the dedicated_device is not a device - name: fail if one of the dedicated_device is not a device
fail: fail:
msg: "{{ item }} is not a block special file!" msg: "{{ item.item }} is not a block special file!"
with_items: "{{ dedicated_device_parted.results }}" with_items: "{{ dedicated_device_parted.results }}"
when: when:
- osd_scenario == 'non-collocated' - osd_scenario == 'non-collocated'