ceph
/
ceph-ansible
mirror of https://github.com/ceph/ceph-ansible.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

container: add always tag on gather fact tasks 

If we execute the site-container.yml playbook with specific tags (like
ceph_update_config) then we need to be sure to gather the facts otherwise
we will see error like:

The task includes an option with an undefined variable. The error was:
'ansible_hostname' is undefined

This commit also adds missing 'gather_facts: false' to mons plays.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1754432

Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
(cherry picked from commit d7fd769b6d)
pull/4749/head
Dimitri Savineau 2019-11-14 09:29:29 -05:00 committed by Guillaume Abrioux
parent e54b6be74e
commit 225d4ceabc
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
site-container.yml.sample
View File

@ -28,8 +28,8 @@
# pre-tasks for following import - # pre-tasks for following import -
- name: gather facts - name: gather facts
setup: setup:
when: when: not delegate_facts_host | bool or inventory_hostname in groups.get(client_group_name, [])
- not delegate_facts_host | bool or inventory_hostname in groups.get(client_group_name, []) tags: always
- name: gather and delegate facts - name: gather and delegate facts
setup: setup:
@ -38,6 +38,7 @@
with_items: "{{ groups['all'] | difference(groups.get('clients', [])) }}" with_items: "{{ groups['all'] | difference(groups.get('clients', [])) }}"
run_once: true run_once: true
when: delegate_facts_host | bool when: delegate_facts_host | bool
tags: always
- import_role: - import_role:
name: ceph-defaults name: ceph-defaults
@ -59,6 +60,7 @@
when: not (inventory_hostname in groups.get('clients', [])) or (inventory_hostname == groups.get('clients', [''])|first) when: not (inventory_hostname in groups.get('clients', [])) or (inventory_hostname == groups.get('clients', [''])|first)
- hosts: mons - hosts: mons
gather_facts: false
any_errors_fatal: true any_errors_fatal: true
tasks: tasks:
- name: set ceph monitor install 'In Progress' - name: set ceph monitor install 'In Progress'
@ -93,6 +95,7 @@
when: groups.get(mgr_group_name, []) | length == 0 when: groups.get(mgr_group_name, []) | length == 0
- hosts: mons - hosts: mons
gather_facts: false
any_errors_fatal: true any_errors_fatal: true
tasks: tasks:
- name: set ceph monitor install 'Complete' - name: set ceph monitor install 'Complete'