ceph
/
ceph-ansible
mirror of https://github.com/ceph/ceph-ansible.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix check mode support 

Adds "check_mode: no" to commands which register cluster state in a
variable and don't modify anything. These commands have to run in order
to support running the playbook in check mode.

Signed-off-by: Gaudenz Steinlin <gaudenz.steinlin@cloudscale.ch>
(cherry picked from commit 3c8987c7a5)
pull/3942/head
Gaudenz Steinlin 2019-05-06 10:14:36 +02:00 committed by Guillaume Abrioux
parent ae9fa7ca09
commit 29650e71d8
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
roles/ceph-facts/tasks/facts.yml
View File

@ -147,6 +147,7 @@
- name: resolve device link(s) - name: resolve device link(s)
command: readlink -f {{ item }} command: readlink -f {{ item }}
changed_when: false changed_when: false
check_mode: no
with_items: "{{ devices }}" with_items: "{{ devices }}"
register: devices_prepare_canonicalize register: devices_prepare_canonicalize
when: when:
@ -256,6 +257,7 @@
command: grep 'osd pool default crush rule' /etc/ceph/{{ cluster }}.conf command: grep 'osd pool default crush rule' /etc/ceph/{{ cluster }}.conf
register: crush_rule_variable register: crush_rule_variable
changed_when: false changed_when: false
check_mode: no
failed_when: false failed_when: false
when: ceph_conf.stat.exists when: ceph_conf.stat.exists

1
roles/ceph-mgr/tasks/mgr_modules.yml
View File

@ -11,6 +11,7 @@
- name: get enabled modules from ceph-mgr - name: get enabled modules from ceph-mgr
command: "{{ docker_exec_cmd_mgr | default('') }} ceph --cluster {{ cluster }} --format json mgr module ls" command: "{{ docker_exec_cmd_mgr | default('') }} ceph --cluster {{ cluster }} --format json mgr module ls"
check_mode: no
changed_when: false changed_when: false
register: _ceph_mgr_modules register: _ceph_mgr_modules
delegate_to: "{{ groups[mon_group_name][0] }}" delegate_to: "{{ groups[mon_group_name][0] }}"