ceph
/
ceph-ansible
mirror of https://github.com/ceph/ceph-ansible.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

update: add default values when setting fact 

This commit adds a default value in the with_dict because when using
python 2.7, if a task using a with_dict has a condition, it is
evaluated anyway whereas in python 3 it isn't.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1766499

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
pull/4699/head
Guillaume Abrioux 2019-10-29 18:19:15 +01:00 committed by Dimitri Savineau
parent 8acb42dc61
commit a5a231b0b6
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
infrastructure-playbooks/rolling_update.yml
View File

@ -486,7 +486,7 @@
- name: set_fact all_mds_name - name: set_fact all_mds_name
set_fact: set_fact:
all_mds_name: "{{ all_mds_name | default([]) + [(_all_mds_name.stdout | from_json)['info'][item.key]['name'] ] }}" all_mds_name: "{{ all_mds_name | default([]) + [(_all_mds_name.stdout | from_json)['info'][item.key]['name'] ] }}"
with_dict: "{{ ((_all_mds_name.stdout | from_json).info) }}" with_dict: "{{ ((_all_mds_name.stdout | default('{}') | from_json).info | default({})) }}"
- name: set max_mds 1 on ceph fs - name: set max_mds 1 on ceph fs
command: "{{ docker_exec_cmd }} ceph --cluster {{ cluster }} fs set {{ cephfs }} max_mds 1" command: "{{ docker_exec_cmd }} ceph --cluster {{ cluster }} fs set {{ cephfs }} max_mds 1"
@ -503,7 +503,7 @@
delay: 1 delay: 1
failed_when: false failed_when: false
until: item not in (deactivate_status.stdout | from_json).mdsmap.in until: item not in (deactivate_status.stdout | from_json).mdsmap.in
with_items: "{{ (_cephfs_status.stdout | from_json).mdsmap.in | difference([0]) | sort(reverse=True) }}" with_items: "{{ (_cephfs_status.stdout | default('{}') | from_json).mdsmap.in | default([]) | difference([0]) | sort(reverse=True) }}"
- name: get name of remaining active mds - name: get name of remaining active mds
command: "{{ docker_exec_cmd }} ceph --cluster {{ cluster }} mds dump -f json" command: "{{ docker_exec_cmd }} ceph --cluster {{ cluster }} mds dump -f json"
@ -513,7 +513,7 @@
- name: set_fact mds_active_name - name: set_fact mds_active_name
set_fact: set_fact:
mds_active_name: "{{ (_mds_active_name.stdout | from_json)['info'][item.key]['name'] }}" mds_active_name: "{{ (_mds_active_name.stdout | from_json)['info'][item.key]['name'] }}"
with_dict: "{{ (_mds_active_name.stdout | from_json).info }}" with_dict: "{{ (_mds_active_name.stdout | default('{}') | from_json).info | default({}) }}"
- name: set_fact mds_active_host - name: set_fact mds_active_host
set_fact: set_fact:
@ -562,6 +562,7 @@
groups: active_mdss groups: active_mdss
ansible_host: "{{ hostvars[mds_active_host if mds_active_host is defined else groups.get(mds_group_name)[0]]['ansible_host'] | default(omit) }}" ansible_host: "{{ hostvars[mds_active_host if mds_active_host is defined else groups.get(mds_group_name)[0]]['ansible_host'] | default(omit) }}"
ansible_port: "{{ hostvars[mds_active_host if mds_active_host is defined else groups.get(mds_group_name)[0]]['ansible_port'] | default(omit) }}" ansible_port: "{{ hostvars[mds_active_host if mds_active_host is defined else groups.get(mds_group_name)[0]]['ansible_port'] | default(omit) }}"
when: groups.get(mds_group_name, []) | length > 0
- name: upgrade active mds - name: upgrade active mds