ceph
/
ceph-ansible
mirror of https://github.com/ceph/ceph-ansible.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

purge-cluster: remove all include tasks 

Including variables from role defaults or files in a group_vars
directory relative to the playbook is a bad practice. We don't want to
do this because including these defaults at the task level overrides
values that would be set in a group_vars directory relative to the
inventory file, which is the correct usage if you wish to override
those default values.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
pull/1284/head
Andrew Schoen 2017-02-07 14:38:02 -06:00
parent 0476b24af1
commit adf6aee643
1 changed files with 0 additions and 54 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
infrastructure-playbooks/purge-cluster.yml
View File

@ -69,12 +69,6 @@
become: true become: true
tasks: tasks:
- include_vars: roles/ceph-common/defaults/main.yml
- include_vars: roles/ceph-mds/defaults/main.yml
- include_vars: group_vars/all.yml
ignore_errors: true
- include_vars: group_vars/{{ mds_group_name }}.yml
ignore_errors: true
- name: stop ceph mdss with systemd - name: stop ceph mdss with systemd
service: service:
@ -106,12 +100,6 @@
become: true become: true
tasks: tasks:
- include_vars: roles/ceph-common/defaults/main.yml
- include_vars: roles/ceph-rgw/defaults/main.yml
- include_vars: group_vars/all.yml
ignore_errors: true
- include_vars: group_vars/{{ rgw_group_name }}.yml
ignore_errors: true
- name: stop ceph rgws with systemd - name: stop ceph rgws with systemd
service: service:
@ -143,12 +131,6 @@
become: true become: true
tasks: tasks:
- include_vars: roles/ceph-common/defaults/main.yml
- include_vars: roles/ceph-rbd-mirror/defaults/main.yml
- include_vars: group_vars/all.yml
ignore_errors: true
- include_vars: group_vars/{{ rbdmirror_group_name }}.yml
ignore_errors: true
- name: stop ceph rbd mirror with systemd - name: stop ceph rbd mirror with systemd
service: service:
@ -175,12 +157,6 @@
become: true become: true
tasks: tasks:
- include_vars: roles/ceph-common/defaults/main.yml
- include_vars: roles/ceph-nfs/defaults/main.yml
- include_vars: group_vars/all.yml
ignore_errors: true
- include_vars: group_vars/{{ nfs_group_name }}.yml
ignore_errors: true
- name: stop ceph nfss with systemd - name: stop ceph nfss with systemd
service: service:
@ -227,10 +203,6 @@
state: absent state: absent
tasks: tasks:
- include_vars: group_vars/all.yml
ignore_errors: true
- include_vars: group_vars/{{ osd_group_name }}.yml
ignore_errors: true
- name: check for a device list - name: check for a device list
fail: fail:
@ -395,15 +367,6 @@
become: true become: true
tasks: tasks:
- include_vars: roles/ceph-common/defaults/main.yml
- include_vars: roles/ceph-mon/defaults/main.yml
- include_vars: roles/ceph-restapi/defaults/main.yml
- include_vars: group_vars/all.yml
ignore_errors: true
- include_vars: group_vars/{{ mon_group_name }}.yml
ignore_errors: true
- include_vars: group_vars/{{ restapi_group_name }}.yml
ignore_errors: true
- name: stop ceph mons with systemd - name: stop ceph mons with systemd
service: service:
@ -607,23 +570,6 @@
gather_facts: false gather_facts: false
tasks: tasks:
- include_vars: roles/ceph-common/defaults/main.yml
- include_vars: group_vars/all.yml
ignore_errors: true
- include_vars: group_vars/{{ mds_group_name }}.yml
ignore_errors: true
- include_vars: group_vars/{{ rgw_group_name }}.yml
ignore_errors: true
- include_vars: group_vars/{{ rbdmirror_group_name }}.yml
ignore_errors: true
- include_vars: group_vars/{{ nfs_group_name }}.yml
ignore_errors: true
- include_vars: group_vars/{{ osd_group_name }}.yml
ignore_errors: true
- include_vars: group_vars/{{ mon_group_name }}.yml
ignore_errors: true
- include_vars: group_vars/{{ restapi_group_name }}.yml
ignore_errors: true
- name: purge fetch directory for localhost - name: purge fetch directory for localhost
file: file: