Right now, under certain OS and Ansible versions, ie Rocky Linux and
ansible-core 2.17, `devices_check` variable is getting defined even if
task was skipped.
That results in set_fact to fail, as resulting variable has no `results`
key in it.
Structure of such variable looks like that:
```
"devices_check": {
"changed": false,
"false_condition": "osd_auto_discovery | default(False) | bool",
"skip_reason": "Conditional result was False",
"skipped": true
}
```
Checking for task not being skipped solves such issues.
Signed-off-by: Dmitriy Rabotyagov <noonedeadpunk@gmail.com>
(cherry picked from commit 9405558d03)
Regression from #7576. Alertmanager placement count was missing
after migration to ceph_orch_apply module
Signed-off-by: Teoman ONAY <tonay@ibm.com>
(cherry picked from commit 31be495061)
If a custom Prometheus port was used before adoption, it was not
taken into account and default 9095 was set instead. Now custom
port is re-applied.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2242346
Signed-off-by: Teoman ONAY <tonay@ibm.com>
(cherry picked from commit b41b7bf869)
ceph orch ls rgw --format=yaml returns multiple documents
when multiple rgw are installed, this was not handled
correctly.
Signed-off-by: Teoman ONAY <tonay@ibm.com>
(cherry picked from commit 823700bc1b)
Support updating crush rule of the pool via crush rule name.
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit d6ac0cc120)
In some scenarios with NVMe, a device might be identified by
Ansible but could actually be a multipath device rather than an
actual device. We need to exclude these as Ceph cannot create
OSDs on them.
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit be9b458524)
networks was at the wrong level in the spec file. Failed with
"got an unexpected keyword argument 'networks'"
Signed-off-by: Teoman ONAY <tonay@ibm.com>
(cherry picked from commit 2c88ecc784)
Alertmanager was bind to default * network instead of grafana_server_addr
as it was before. Now on if grafana_server_addr is defined, it will be
bind to that network.
Signed-off-by: Teoman ONAY <tonay@ibm.com>
(cherry picked from commit 0bf3398774)
RGW currently restarts without waiting for existing connections to
close. By adjusting the HAProxy weight before the restart, we can
ensure that no active connections are disrupted during the restart
process.
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit 4fa9057a3e)
As is idempotency does not work as the ceph orch
output does contain more attributes than the expected
spec.
Signed-off-by: Teoman ONAY <tonay@ibm.com>
(cherry picked from commit 5a44fbeaa6)
Add new module ceph_orch_spec which applies ceph spec files.
This feature was needed to bind extra mount points to the RGW
container (/etc/pki/ca-trust/).
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2262133
Signed-off-by: Teoman ONAY <tonay@ibm.com>
(cherry picked from commit f6fd034e7e)
Use --setuser and --setgroup to ceph to run daemons with ceph user.
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit 7016c6df3c)
Make it the same as "Create ceph initial directories" task
and make owner and group 167 for containers so they can write
with ceph user.
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit 65c84a3583)
This is needed by ceph-exporter as it is parsing the socket by the number of dots.
Although the rgw_zone variable is only using for constructing the client name
and has nothing to do with multisiting.
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit 1121e6d98a)
Fixes cephadm-adopt test scenario by configuring rbd application
on test and test2 pools. Otherwise cephadm-adopt failed at task
"Check pools have an application enabled"
Signed-off-by: Teoman ONAY <tonay@ibm.com>
(cherry picked from commit ca191fad2a)
Set return code to 0 on check mode when the user doesn't exists and it will fail the module.
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit 878cce5b48)
ba7eb62a1b broke deployments where
mgrs are not collocated with mons.
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 4f6641fe5c)
so you don't have to implement a similar play on your own
if not using main (sample) playbooks.
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit ba7eb62a1b)
Although custom cluster name support was dropped, it breaks ceph-volume
functional testing as it uses "test" as cluster name.
The plan is to make ceph-volume use "ceph" but for now it's easier to
address the issue in this task.
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit c4b3520730)
ceph-volume has a dependency on `python3-packaging` which is available
in PowerTools repo.
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 8ebff2124d)
If rgw is configured to only operate admin api - this is the status code it will return for GET on no path.
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit 9f9b32e9e6)
This moves the tmpdir removal tasks to main playbook.
The handlers in Ansible are too restrictive and doesn't work
quite well for our use case.
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit bab034024c)
nfs-ganesha support will be implemented in a separate playbook.
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 675667e1d6)
this was for backward compatibility concerns, it's time to drop this
task.
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit d9e2de1d1d)
this is needed in order to make some libraries available when
running on RockyLinux
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 867be7c35c)
This enforces docker.io and docker respectively for
`container_package_name` and `container_service_name` by default
for Ubuntu distribution.
Fixes: #7496
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit ef5a09d0e0)
Check the current value and asked both in low case as the asked one might be in capital as it should be.
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit ed4b6e71b3)
The returned payload from rgw has them as a boolean. By having them as a string it would always report a change and try to modify the user.
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit a95726c409)
Ceph return them as string so in comparision it would always fail
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit f0b4cc3f0d)
RGW Pools can now use the existing ec profiles and rules created by ceph-osd role.
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit bbc1ba5c05)
The returned payload from rgw has is_master as a boolean. By having master as a string it would always report a change and try to modify the zonegroup.
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit e8d34b6ee6)
Dmitriy Rabotyagov
Teoman ONAY
Amir Nikpour
Seena Fallah
Guillaume Abrioux