kubernetes-sigs
/
kubespray
mirror of https://github.com/kubernetes-sigs/kubespray.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove deprecated crio_pids_limits (#10056) 

As per https://github.com/cri-o/cri-o/pull/5831, option is now
deprecated.
pull/10118/head
James 2023-05-22 15:49:03 +00:00 committed by GitHub
parent 4b67c7d6a6
commit 161bd55ab2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 0 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
docs/cri-o.md
View File

@ -40,21 +40,7 @@ crio_registries:
insecure: false insecure: false
``` ```
## Note about pids_limit
For heavily mult-threaded workloads like databases, the default of 1024 for pids-limit is too low.
This parameter controls not just the number of processes but also the amount of threads
(since a thread is technically a process with shared memory). See [cri-o#1921]
In order to increase the default `pids_limit` for cri-o based deployments you need to set the `crio_pids_limit`
for your `k8s_cluster` ansible group or per node depending on the use case.
```yaml
crio_pids_limit: 4096
```
[CRI-O]: https://cri-o.io/ [CRI-O]: https://cri-o.io/
[cri-o#1921]: https://github.com/cri-o/cri-o/issues/1921
## Note about user namespaces ## Note about user namespaces

4
roles/container-engine/cri-o/defaults/main.yml
View File

@ -73,10 +73,6 @@ youki_runtime:
crio_download_base: "download.opensuse.org/repositories/devel:kubic:libcontainers:stable" crio_download_base: "download.opensuse.org/repositories/devel:kubic:libcontainers:stable"
crio_download_crio: "http://{{ crio_download_base }}:/cri-o:/" crio_download_crio: "http://{{ crio_download_base }}:/cri-o:/"
# Configure the cri-o pids limit, increase this for heavily multi-threaded workloads
# see https://github.com/cri-o/cri-o/issues/1921
crio_pids_limit: 1024
# Reserve 16M uids and gids for user namespaces (256 pods * 65536 uids/gids) # Reserve 16M uids and gids for user namespaces (256 pods * 65536 uids/gids)
# at the end of the uid/gid space # at the end of the uid/gid space
crio_remap_enable: false crio_remap_enable: false

3
roles/container-engine/cri-o/templates/crio.conf.j2
View File

@ -205,9 +205,6 @@ default_mounts = [
# #
#default_mounts_file = "" #default_mounts_file = ""
# Maximum number of processes allowed in a container.
pids_limit = {{ crio_pids_limit }}
# Maximum sized allowed for the container log file. Negative numbers indicate # Maximum sized allowed for the container log file. Negative numbers indicate
# that no size limit is imposed. If it is positive, it must be >= 8192 to # that no size limit is imposed. If it is positive, it must be >= 8192 to
# match/exceed conmon's read buffer. The file is truncated and re-opened so the # match/exceed conmon's read buffer. The file is truncated and re-opened so the