kubernetes-sigs
/
kubespray
mirror of https://github.com/kubernetes-sigs/kubespray.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Drop chech for kubelet_shutdown_grace_period (#7993) 

and kubelet_shutdown_grace_period_critical_pods as ansible cannot do
sane time interval calculations
pull/8000/head
Cristian Calin 2021-09-22 04:34:00 +03:00 committed by GitHub
parent 2211504790
commit a517a8db01
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
inventory/sample/group_vars/k8s_cluster/k8s-cluster.yml
View File

@ -150,6 +150,8 @@ kube_proxy_nodeport_addresses: >-
kube_encrypt_secret_data: false kube_encrypt_secret_data: false
# Graceful Node Shutdown (Kubernetes >= 1.21.0), see https://kubernetes.io/blog/2021/04/21/graceful-node-shutdown-beta/ # Graceful Node Shutdown (Kubernetes >= 1.21.0), see https://kubernetes.io/blog/2021/04/21/graceful-node-shutdown-beta/
# kubelet_shutdown_grace_period had to be greater than kubelet_shutdown_grace_period_critical_pods to allow
# non-critical podsa to also terminate gracefully
# kubelet_shutdown_grace_period: 60s # kubelet_shutdown_grace_period: 60s
# kubelet_shutdown_grace_period_critical_pods: 20s # kubelet_shutdown_grace_period_critical_pods: 20s

7
roles/kubernetes/preinstall/tasks/0020-verify-settings.yml
View File

@ -107,13 +107,6 @@
- not ignore_assert_errors - not ignore_assert_errors
- inventory_hostname in groups['kube_node'] - inventory_hostname in groups['kube_node']
- name: Stop when ShutdownGracePeriod less than ShutdownGracePeriodCriticalPods
assert:
that: kubelet_shutdown_grace_period > kubelet_shutdown_grace_period_critical_pods
msg: "ShutdownGracePeriod ({{ kubelet_shutdown_grace_period }}) needs to be greater than ShutdownGracePeriodCriticalPods ({{ kubelet_shutdown_grace_period_critical_pods }}) in order to give normal pods time to be evacuated, please see https://kubernetes.io/blog/2021/04/21/graceful-node-shutdown-beta/ for details"
when:
- kube_version is version('v1.21.0', '>=')
- name: Stop when dynamic_kubelet_configuration enabled for kubernetes >= 1.22 - name: Stop when dynamic_kubelet_configuration enabled for kubernetes >= 1.22
assert: assert:
that: not dynamic_kubelet_configuration that: not dynamic_kubelet_configuration