kubernetes-sigs
/
kubespray
mirror of https://github.com/kubernetes-sigs/kubespray.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix `dns_prevent_single_point_failure` variable (#3728) 

comparison that happens during `TASK [kubernetes-apps/ansible : Kubernetes Apps | Lay Down CoreDNS Template]` where the `dns-autoscaler` template is deployed causes coredns to fail deployment.  The error is caused by the variable `dns_prevent_single_point_failure` where an integer is being compared with a string. The resulting error:

```bash
'>' not supported between instances of 'int' and 'str'
```

prevents successful deployment of CoreDNS.  

The change makes the comparison happen between integers and allows CoreDNS to succeed.
pull/3731/head
marcstreeter 2018-11-17 01:57:47 -06:00 committed by k8s-ci-robot
parent 9d0786cbb0
commit c83bfc9df6
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
roles/kubernetes-apps/ansible/defaults/main.yml
View File

@ -10,7 +10,7 @@ dns_memory_requests: 70Mi
dns_min_replicas: 2
dns_nodes_per_replica: 10
dns_cores_per_replica: 20
dns_prevent_single_point_failure: "{{ 'true' if dns_min_replicas > '1' else 'false' }}"
dns_prevent_single_point_failure: "{{ 'true' if dns_min_replicas > 1 else 'false' }}"
# Images
image_arch: "{{host_architecture}}"