kubernetes-sigs
/
kubespray
mirror of https://github.com/kubernetes-sigs/kubespray.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Check all places with `check_mode: no` for side effects (#8573) 

and fix the one with side effect.

Also removes `notify` from this task as the task has `changed_when: false`
and notify is not going to fire.
pull/8572/head
Ilya Margolin 2022-02-23 10:20:18 +01:00 committed by GitHub
parent 1d46c07307
commit e053ee4272
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
roles/etcd/tasks/gen_certs_script.yml
View File

@ -156,11 +156,9 @@
executable: /bin/bash executable: /bin/bash
no_log: true no_log: true
changed_when: false changed_when: false
check_mode: no
when: (('calico_rr' in groups and inventory_hostname in groups['calico_rr']) or when: (('calico_rr' in groups and inventory_hostname in groups['calico_rr']) or
inventory_hostname in groups['k8s_cluster']) and inventory_hostname in groups['k8s_cluster']) and
sync_certs|default(false) and inventory_hostname not in groups['etcd'] sync_certs|default(false) and inventory_hostname not in groups['etcd']
notify: set etcd_secret_changed
- name: Gen_certs | check certificate permissions - name: Gen_certs | check certificate permissions
file: file: