llvm
/
torch-mlir
mirror of https://github.com/llvm/torch-mlir
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

python: add `CHECK-LABEL` statements to localize checks (#1363) 

It seems as though an upstream change in PyTorch has caused the module
dump to include not just the module being tested, but also several
seemingly unrelated functions in the `torch._decom.decompositions`
namespace.  The presence of these new functions caused lit to match
variables against incorrect statements (i.e.  statements in the
unrelated functions instead of the module under test).

This patch inserts `CHECK-LABEL` statements in the failing tests so that
lit ignores these unrelated functions and only checks the statements at
or after the test module definition.
pull/1359/head
Ashay Rane 2022-09-13 15:44:13 -05:00 committed by GitHub
parent 1c8b389ead
commit a9e1014fc7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
test/python/importer/jit_ir/ivalue_import/object-identity-torch-bug.py
View File

@ -18,6 +18,7 @@ mb = ModuleBuilder()
# `torch.Tensor` is just a pointer to a TensorImpl under the hood, and so # `torch.Tensor` is just a pointer to a TensorImpl under the hood, and so
# naively duplicating a Tensor retains the identity of the TensorImpl. # naively duplicating a Tensor retains the identity of the TensorImpl.
# CHECK-LABEL: torch.class_type @__torch__.TestModule {
class TestModule(torch.nn.Module): class TestModule(torch.nn.Module):
def __init__(self): def __init__(self):
super().__init__() super().__init__()

1
test/python/importer/jit_ir/ivalue_import/quantization.py
View File

@ -12,6 +12,7 @@ from torch_mlir.dialects.torch.importer.jit_ir import ModuleBuilder
mb = ModuleBuilder() mb = ModuleBuilder()
# CHECK-LABEL: torch.class_type @__torch__.TestModule {
class TestModule(torch.nn.Module): class TestModule(torch.nn.Module):
def __init__(self): def __init__(self):
super().__init__() super().__init__()

1
test/python/importer/jit_ir/ivalue_import/submodules.py
View File

@ -22,6 +22,7 @@ class TestModule(torch.nn.Module):
self.s0 = Submodule(0) self.s0 = Submodule(0)
self.s1 = Submodule(1) self.s1 = Submodule(1)
# CHECK-LABEL: torch.class_type @__torch__.TestModule {
# CHECK: %[[T:.*]] = torch.constant.bool true # CHECK: %[[T:.*]] = torch.constant.bool true
# CHECK: %[[N0:.*]] = torch.constant.int 0 # CHECK: %[[N0:.*]] = torch.constant.int 0